Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532AbdIMAoy (ORCPT ); Tue, 12 Sep 2017 20:44:54 -0400 Received: from mail-pg0-f50.google.com ([74.125.83.50]:37475 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbdIMAox (ORCPT ); Tue, 12 Sep 2017 20:44:53 -0400 X-Google-Smtp-Source: ADKCNb5EUVOOIFZ0LkixyXZP6+183QkmDH+21GR9JCdq2hPKGSEpHC8PVOldcXc2m6NlIUI+/6hfTw== Date: Wed, 13 Sep 2017 09:46:47 +0900 From: AKASHI Takahiro To: Dave Young Cc: catalin.marinas@arm.com, will.deacon@arm.com, bauerman@linux.vnet.ibm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, mpe@ellerman.id.au, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/9] kexec_file: factor out crashdump elf header function from x86 Message-ID: <20170913004645.GI17186@linaro.org> Mail-Followup-To: AKASHI Takahiro , Dave Young , catalin.marinas@arm.com, will.deacon@arm.com, bauerman@linux.vnet.ibm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, mpe@ellerman.id.au, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20170908031616.17916-1-takahiro.akashi@linaro.org> <20170908031616.17916-4-takahiro.akashi@linaro.org> <20170912055521.GA8787@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170912055521.GA8787@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1742 Lines: 54 On Tue, Sep 12, 2017 at 01:55:21PM +0800, Dave Young wrote: > Hi, > On 09/08/17 at 12:16pm, AKASHI Takahiro wrote: > [snip] > > --- a/include/linux/kexec.h > > +++ b/include/linux/kexec.h > > @@ -162,6 +162,25 @@ int __weak arch_kexec_walk_mem(struct kexec_buf *kbuf, > > int (*func)(u64, u64, void *)); > > extern int kexec_add_buffer(struct kexec_buf *kbuf); > > int kexec_locate_mem_hole(struct kexec_buf *kbuf); > > +#ifdef CONFIG_CRASH_CORE > > +extern int prepare_elf_headers(struct kimage *image, void **addr, > > + unsigned long *sz); > > + > > +/* This primarily represents number of split ranges due to exclusion */ > > +#define CRASH_MAX_RANGES 16 > > + > > +struct crash_mem_range { > > + u64 start, end; > > +}; > > + > > +struct crash_mem { > > + unsigned int nr_ranges; > > + struct crash_mem_range ranges[CRASH_MAX_RANGES]; > > +}; > > + > > +extern int exclude_mem_range(struct crash_mem *mem, > > + unsigned long long mstart, unsigned long long mend); > > +#endif /* CONFIG_CRASH_CORE */ > > Maybe I did not say it clear when reviewing the v1. > > I suggested to move the code from to kexec_file.c because the (from crash_core.c) > CONFIG_CRASH_CORE originally was introduced for the common code for > vmcoreinfo stuff when Hari worked on sharing code between powerpc > fadump and kdump. > > I'm not sure we need the #ifdef CONFIG_CRASH_CORE here for these > kexec file load functions. Since they are already in kexec_file.c > so I think no need to add the #ifdef Right. CRASH_CORE is always selected, in arch/Kconfig, by KEXEC_CORE which is selected by KEXEC_FILE. (In this sense, CRASH_CORE has no use any more.) Thanks, -Takahiro AKASHI > > #endif /* CONFIG_KEXEC_FILE */ > Thanks > Dave