Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751645AbdIMArO (ORCPT ); Tue, 12 Sep 2017 20:47:14 -0400 Received: from mga09.intel.com ([134.134.136.24]:32830 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbdIMArM (ORCPT ); Tue, 12 Sep 2017 20:47:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,384,1500966000"; d="scan'208";a="150643911" Date: Tue, 12 Sep 2017 17:47:03 -0700 From: Jarkko Sakkinen To: Nayna Jain Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, patrickc@us.ibm.com Subject: Re: [PATCH v2 4/4] tpm: use tpm_msleep() value as max delay Message-ID: <20170913004703.wtebzfp7mlgk57xf@linux.intel.com> References: <20170906125643.5070-1-nayna@linux.vnet.ibm.com> <20170906125643.5070-5-nayna@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906125643.5070-5-nayna@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 37 On Wed, Sep 06, 2017 at 08:56:39AM -0400, Nayna Jain wrote: > Currently, tpm_msleep() uses delay_msec as the minimum value in > usleep_range. However, that is the maximum time we want to wait. > The function is modified to use the delay_msec as the maximum > value, not the minimum value. > > After this change, performance on a TPM 1.2 with an 8 byte > burstcount for 1000 extends improved from ~9sec to ~8sec. > > Signed-off-by: Nayna Jain > Acked-by: Mimi Zohar > --- > drivers/char/tpm/tpm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > index eb2f8818eded..ff5a8b7b80b9 100644 > --- a/drivers/char/tpm/tpm.h > +++ b/drivers/char/tpm/tpm.h > @@ -533,8 +533,8 @@ int wait_for_tpm_stat(struct tpm_chip *chip, u8 mask, unsigned long timeout, > > static inline void tpm_msleep(unsigned int delay_msec) > { > - usleep_range(delay_msec * 1000, > - (delay_msec * 1000) + TPM_TIMEOUT_RANGE_US); > + usleep_range((delay_msec * 1000) - TPM_TIMEOUT_RANGE_US, > + delay_msec * 1000); > }; > > struct tpm_chip *tpm_chip_find_get(int chip_num); > -- > 2.13.3 > Doesn't this need a Fixes tag? /Jarkko