Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751815AbdIMBkh (ORCPT ); Tue, 12 Sep 2017 21:40:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44110 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbdIMBkf (ORCPT ); Tue, 12 Sep 2017 21:40:35 -0400 Date: Tue, 12 Sep 2017 18:40:34 -0700 From: Greg Kroah-Hartman To: "Luis R. Rodriguez" Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Torvalds , Gabriel C , Arend Van Spriel Subject: Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend" Message-ID: <20170913014034.GA24589@kroah.com> References: <20170912165308.904472972@linuxfoundation.org> <20170912165310.407586301@linuxfoundation.org> <20170912172008.GF16216@wotan.suse.de> <20170913004758.GA21439@kroah.com> <20170913012252.GL16216@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170913012252.GL16216@wotan.suse.de> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 26 On Wed, Sep 13, 2017 at 03:22:52AM +0200, Luis R. Rodriguez wrote: > On Tue, Sep 12, 2017 at 05:47:58PM -0700, Greg Kroah-Hartman wrote: > > On Tue, Sep 12, 2017 at 07:20:08PM +0200, Luis R. Rodriguez wrote: > > > On Tue, Sep 12, 2017 at 10:00:00AM -0700, Greg Kroah-Hartman wrote: > > > > 4.13-stable review patch. If anyone has any objections, please let me know. > > > > > > > > ------------------ > > > > > > > > From: Linus Torvalds > > > > > > > > commit f007cad159e99fa2acd3b2e9364fbb32ad28b971 upstream. > > > > > > > > This reverts commit 81f95076281fdd3bc382e004ba1bce8e82fccbce. > > > > > > I'm not convinced reverting this commit is the right thing to do at > > > this point given it would seem other errors were happening prior to > > > v4.13 and this commit would rather just bring to light the core of > > > the issue which needs to be addressed. > > > > Given that this fixes a reported regression, yes, it is the right thing > > to do. > > Once 06a45a93e7d34a is also reverted I believe it may be revealed this was > not a regression after all. Then we will put it back :)