Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751876AbdIMDqD (ORCPT ); Tue, 12 Sep 2017 23:46:03 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37310 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbdIMDp6 (ORCPT ); Tue, 12 Sep 2017 23:45:58 -0400 Date: Tue, 12 Sep 2017 20:45:57 -0700 (PDT) Message-Id: <20170912.204557.891051979478318768.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ast@fb.com Subject: Re: [PATCH v4 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect_md mode From: David Miller In-Reply-To: <1505209677-12728-2-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1505209677-12728-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1505209677-12728-2-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Sep 2017 20:45:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 16 From: Haishuang Yan Date: Tue, 12 Sep 2017 17:47:57 +0800 > In collect_md mode, if the tun dev is down, it still can call > __ip6_tnl_rcv to receive on packets, and the rx statistics increase > improperly. > > When the md tunnel is down, it's not neccessary to increase RX drops > for the tunnel device, packets would be recieved on fallback tunnel, > and the RX drops on fallback device will be increased as expected. > > Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") > Cc: Alexei Starovoitov > Signed-off-by: Haishuang Yan Applied.