Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbdIMIbv (ORCPT ); Wed, 13 Sep 2017 04:31:51 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:46442 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751020AbdIMIbt (ORCPT ); Wed, 13 Sep 2017 04:31:49 -0400 Date: Wed, 13 Sep 2017 11:31:46 +0300 From: Sakari Ailus To: Ricardo Ribalda Delgado Cc: Laurent Pinchart , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Tiffany Lin , Wu-Cheng Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum Message-ID: <20170913083146.hs7amre3ajddkdy2@valkosipuli.retiisi.org.uk> References: <20170913073552.29806-1-ricardo.ribalda@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170913073552.29806-1-ricardo.ribalda@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 41 On Wed, Sep 13, 2017 at 09:35:52AM +0200, Ricardo Ribalda Delgado wrote: > max_width and max_height are swap with step_width and step_height. > > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Sakari Ailus > --- > > Since that this bug has been here for ever. I do not know if we should > notify stable or not > > I have also cut the lines to respect the 80 char limit > > v2: Suggested by Laurent Pinchart > -Fix indentation > > drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index b60a6b0841d1..0292f327467d 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -730,9 +730,9 @@ static void v4l_print_frmsizeenum(const void *arg, bool write_only) > break; > case V4L2_FRMSIZE_TYPE_STEPWISE: > pr_cont(", min=%ux%u, max=%ux%u, step=%ux%u\n", > - p->stepwise.min_width, p->stepwise.min_height, > - p->stepwise.step_width, p->stepwise.step_height, > - p->stepwise.max_width, p->stepwise.max_height); > + p->stepwise.min_width, p->stepwise.min_height, > + p->stepwise.max_width, p->stepwise.max_height, > + p->stepwise.step_width, p->stepwise.step_height); > break; > case V4L2_FRMSIZE_TYPE_CONTINUOUS: > /* fall through */ -- Sakari Ailus e-mail: sakari.ailus@iki.fi