Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbdIMJLw (ORCPT ); Wed, 13 Sep 2017 05:11:52 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:49609 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdIMJLs (ORCPT ); Wed, 13 Sep 2017 05:11:48 -0400 X-AuditID: b6c32a36-f79196d0000051db-4b-59b8f6518753 Subject: Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits To: Hoegeun Kwon Cc: mchehab@kernel.org, inki.dae@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, m.szyprowski@samsung.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org From: Sylwester Nawrocki Message-id: Date: Wed, 13 Sep 2017 11:11:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="utf-8" Content-language: en-GB Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjmO+ds50xafc3bS0HSyCBFnVH6QaWFRpMkrV/anzrkwUKnY9NI oYuYmWtecEWiZRfKQuZtqZlpiZe0pKnZKsu0HA3tMu2i2QUsdxT897zv+zzv8z4fH0cr3khW cUdS0gRdCp+slLoxjR0bVAF7Z5riVa9ml5F862OKTFYYEbnSaZWQ59OTUjJ5yyAlxaNFDCm0 f6JJX18tSyz2FxIy2HxJSoy1DRJS0veAIlWdb1ly8+UARSosfymS09rJkomvPcz2lWpzuRmp LZV5UvXdmXcS9ei5bkp958ZJdUF9JVJ/t6yJZfe7bU0Qko8cFXRBYQfdDhvKW5H2N3ds6oeN PYUusgYk4wBvAntOESNiL+gfqZEakBunwE0Ibo/VI7H4ieCWvVm6qHDkzFHioBbBU+erBdYo AsfsuGuvO44Ge8OUC3tgf/j8K5+eJ9G4nAbHh/cuQykOhvyugv9qjpPjMHiZt2O+zWBfmC4r pOaxJ46Dxp8lLmc5XgmzphGXVIbDoeZ0m6tP4w0w/qOYEbE3PBodQiL2gTvmLy5fwNUs5OUX LISOhN4z2ZSI3eFjdz07fwPg1fCsa5vIL0TQY85GYlGCYDi3aEGwBTq6BySiw3JwThslolgO Z88oRIoa+rOsCzt3QNbl3eIDdVHgaC5mi5BP6ZI8pUsylC7JULokw1XEVCIvQavXJAr6YO3G QD2v0aenJAYeStVYkOvL+YU0oevW6HaEOaRcJo99fTdeIeGP6jM07Qg4Wukhf/StKV4hT+Az MgVd6gFderKgb0erOUbpLfeseRGnwIl8mpAkCFpBtzilONmqU6ht8EFZ1c5r7kF/bMGVM1vD zEFfdm0K4Od6YvzSGtZFxN+rris0DasMHQ9zq9fTURfO1V32vW1bOxTVpnJOTD3hhel9eOC+ MdQWPdgSed4UoWqZPZQbcmlbb2zmiph+wdQqKwutS03K2HPC/7gjaci+2YOR2a6uCGowjXlF hDtzlIz+MB/sR+v0/D8tPnWlbgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t9jQd2AbzsiDX5fN7LoPXeSyeL9sh5G i/lHzrFaXPn6ns3i/fIuNotJ9yewWPQ/fs1scf78BnaLTY+vsVpc3jWHzaJnw1ZWixnn9zFZ rD1yl91i6fWLTBbLNv1hsmjde4Td4uXHEywOgh5r5q1h9Ni0qpPNY/u3B6we97uPM3lsXlLv 0bdlFaPH501yAexRXDYpqTmZZalF+nYJXBld8/YyFvziqPjw5Sp7A+N09i5GTg4JAROJZ63/ mboYuTiEBNYxSjTtPgXlPGSUeLlqMQtIlbCAj8TjrR/AOkQEtCXe/OxlBiliFpjHLPHnzG1G iI6jTBJXVj1iAqliEzCU6D3aB5Tg4OAVsJO43ukIEmYRUJX4OrsfrERUIEKi7+1lsKG8AoIS PybfA1vGKWAvsb7lABtIK7OAusSUKbkgYWYBcYlj928yQtjyEpvXvGWewCgwC0n3LISOWUg6 ZiHpWMDIsopRMrWgODc9t9iowDAvtVyvODG3uDQvXS85P3cTIzD2th3W6tvBeH9J/CFGAQ5G JR7eFXe2RwqxJpYVV+YeYpTgYFYS4T32aUekEG9KYmVValF+fFFpTmrxIUZpDhYlcd7MvhmR QgLpiSWp2ampBalFMFkmDk6pBsbUneGXdDZyLN2Rznns7wEnvsMnLj2d9/1T0UaWCdqny3aX KKTcPLhKN3RWkfxa8x9WS+YcStz6aob0ruKpT7NFHt2+bPrF9Y7Fy2i/+8q8PU8m/9FLlCv9 XsnZNG/mWnO/yPZWxYu/fPtVIpiEvm/TNBToucprmCGi6rbnbsGsmZPP390YVyasxFKckWio xVxUnAgAFlEeCrkCAAA= X-CMS-MailID: 20170913091144epcas1p24be898642d7140a4011cdd436a9d48c4 X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170908060309epcas1p3d48dd0871d3fde02ba3c9921bbe5a7a6 X-RootMTR: 20170908060309epcas1p3d48dd0871d3fde02ba3c9921bbe5a7a6 References: <1504850560-27950-1-git-send-email-hoegeun.kwon@samsung.com> <1504850560-27950-5-git-send-email-hoegeun.kwon@samsung.com> <27b46679-e6c7-2471-f10e-3f0634178ebf@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 30 Hi Hoegeun, On 09/13/2017 04:33 AM, Hoegeun Kwon wrote: >>> @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq, >>> void *priv) >>> static const struct of_device_id exynos_gsc_match[] = { >>> { >>> - .compatible = "samsung,exynos5-gsc", >>> - .data = &gsc_v_100_drvdata, >> Can you keep the "samsung,exynos5-gsc" entry with the gsc_v_5250_variant >> data, so that it can work with "samsung,exynos5-gsc" compatible in DT >> on both exynos5250 and exynos5420 SoCs? >> > Thank you for your question. > > Exynos 5250 and 5420 have different hardware rotation limits. > Exynos 5250 is '.real_rot_en_w/h = 2016' and 5420 is '.real_rot_en_w/h = > 2048'. > > So my opinion they must have different compatible. I think there is some misunderstanding, mu suggestion was to keep the "samsung,exynos5-gsc" compatible entry in addition to the new introduced ones: "samsung,exynos5250-gsc" and "samsung,exynos5420-gsc". That's in order to make your changes possibly backward compatible, in theory the updated driver should still work without changes in dts. -- Regards, Sylwester