Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752201AbdIMJ2G (ORCPT ); Wed, 13 Sep 2017 05:28:06 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:53952 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbdIMJ2D (ORCPT ); Wed, 13 Sep 2017 05:28:03 -0400 X-AuditID: b6c32a48-f79a16d00000362a-10-59b8fa214a73 Subject: Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits To: Sylwester Nawrocki Cc: mchehab@kernel.org, inki.dae@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, m.szyprowski@samsung.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Hoegeun Kwon From: Hoegeun Kwon Message-id: <21b6ae5d-a77b-3ab1-bc84-5f30e76fab50@samsung.com> Date: Wed, 13 Sep 2017 18:28:02 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKJsWRmVeSWpSXmKPExsWy7bCmua7irx2RBj+WsFv0njvJZPF+WQ+j xfwj51gtrnx9z2bxfnkXm8Wk+xNYLPofv2a2OH9+A7vFpsfXWC0u75rDZtGzYSurxYzz+5gs 1h65y26x9PpFJotlm/4wWbTuPcJucfhNO6vFy48nWByEPNbMW8PosWlVJ5vH9m8PWD3udx9n 8ti8pN6jb8sqRo/Pm+QC2KNSbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPIS c1NtlVx8AnTdMnOA3lBSKEvMKQUKBSQWFyvp29kU5ZeWpCpk5BeX2CpFGxoa6RkamOsZGRnp mRjHWhmZApUkpGb8mDaHreAxV8W7eT9YGxhvcnQxcnJICJhIzD8+ixnCFpO4cG89WxcjF4eQ wA5GifkXXzBDON8ZJbZMf84O03FgYiMjRGI3o8S81i9QVXcZJX4ufAc2S1jAR+Lx1g9gHSIC +hJLVl0Em8sscJJZ4snSCSwgCTYBXYmvPdeZQGxeATuJxnUf2UBsFgFViYlLzjCC2KICERLb vs9gg6gRlPgx+R5QLwcHp4C9xL4HPCBhZgEriWf/WlkhbHmJzWveMkPY4hLNrTdZQPZKCGxj l3h1YR3UCy4S1zZ9ZoGwhSVeHd8CFZeWeLZqIyOEXS9xecdJRojmBkaJ/omzoYqMJU51NTJB bOCT6Dj8lx3kIAkBXomONiGIEg+JC43noMKOEo1zvSEB9ItJYsqfy0wTGOVnIXlnFpIfZiH5 YRaSHxYwsqxiFEstKM5NTy02KjDRK07MLS7NS9dLzs/dxAhO0loeOxgPnPM5xCjAwajEwxtw a3ukEGtiWXFl7iFGCQ5mJRHeY592RArxpiRWVqUW5ccXleakFh9iNAUG90RmKdHkfGAGySuJ NzSxNDAxMzMyN7MAJj1x3rpt1yKEBNITS1KzU1MLUotg+pg4OKUaGEMCuRhTlI1CHOY+9pq5 Z39wVku/a8+2IDMz1uV692zm5qz7pZOeferQLhE2B/+sJ/tO7dh6tc85uZZLO2n3Q26Bjy43 p/wodjGJPGf75d+O3qMBSXmFc98FsixxmTHfqvysEOv2dQoCSdEvDnHbsZ5q1pwoU7VRvmzp hbXXmQRXCZ7lMzjAp8RSnJFoqMVcVJwIAP2HmRnoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsVy+t9jAV2FXzsiDfp+GFn0njvJZPF+WQ+j xfwj51gtrnx9z2bxfnkXm8Wk+xNYLPofv2a2OH9+A7vFpsfXWC0u75rDZtGzYSurxYzz+5gs 1h65y26x9PpFJotlm/4wWbTuPcJucfhNO6vFy48nWByEPNbMW8PosWlVJ5vH9m8PWD3udx9n 8ti8pN6jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4Mn5Mm8NW8Jir4t28H6wNjDc5uhg5OSQE TCQOTGxk7GLk4hAS2MkocXrpGRYI5z6jRNejm6wgVcICPhKPt35gB7FFBPQllqy6yAZSxCxw klnizuFv7BAdv5gkOqd+YAKpYhPQlfjacx3M5hWwk2hc95ENxGYRUJWYuOQMI4gtKhAh0ff2 MjtEjaDEj8n3gFZzcHAK2Evse8ADEmYWMJP48vIwK4QtL7F5zVtmCFtcorn1JssERoFZSLpn IWmZhaRlFpKWBYwsqxglUwuKc9Nzi40KjPJSy/WKE3OLS/PS9ZLzczcxAiNx22Gt/h2Mj5fE H2IU4GBU4uFdcWd7pBBrYllxZe4hRgkOZiUR3mOfdkQK8aYkVlalFuXHF5XmpBYfYpTmYFES 583smxEpJJCeWJKanZpakFoEk2Xi4JRqYFy4MM98VsvbFW+uq50Q9n999uUHw4kNB88uf/O3 k/VV/ixDvpAAS5tnf54x33ey6WY9ZhMu9vJO2Tm+Nu/8Jzy1J7/+/VMtyBCnqW9Tov+LKyRy An+5za90DlNrjfWN8qXmH++lfCpmNjyw5/BFg5NrFX+/5lQ+et599h7m9H7eHI7tkvU7fiix FGckGmoxFxUnAgCOuds0wAIAAA== X-CMS-MailID: 20170913092800epcas2p4ddab4db7c56f97e51a118f5a4f4ec785 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170908060309epcas1p3d48dd0871d3fde02ba3c9921bbe5a7a6 X-RootMTR: 20170908060309epcas1p3d48dd0871d3fde02ba3c9921bbe5a7a6 References: <1504850560-27950-1-git-send-email-hoegeun.kwon@samsung.com> <1504850560-27950-5-git-send-email-hoegeun.kwon@samsung.com> <27b46679-e6c7-2471-f10e-3f0634178ebf@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 36 On 09/13/2017 06:11 PM, Sylwester Nawrocki wrote: > Hi Hoegeun, > > On 09/13/2017 04:33 AM, Hoegeun Kwon wrote: >>>> @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq, >>>> void *priv) >>>> static const struct of_device_id exynos_gsc_match[] = { >>>> { >>>> - .compatible = "samsung,exynos5-gsc", >>>> - .data = &gsc_v_100_drvdata, >>> Can you keep the "samsung,exynos5-gsc" entry with the gsc_v_5250_variant >>> data, so that it can work with "samsung,exynos5-gsc" compatible in DT >>> on both exynos5250 and exynos5420 SoCs? >>> >> Thank you for your question. >> >> Exynos 5250 and 5420 have different hardware rotation limits. >> Exynos 5250 is '.real_rot_en_w/h = 2016' and 5420 is '.real_rot_en_w/h = >> 2048'. >> >> So my opinion they must have different compatible. > I think there is some misunderstanding, mu suggestion was to keep the > "samsung,exynos5-gsc" compatible entry in addition to the new introduced > ones: "samsung,exynos5250-gsc" and "samsung,exynos5420-gsc". That's in > order to make your changes possibly backward compatible, in theory > the updated driver should still work without changes in dts. Thank you again for your explanation. Yes, I understood. I will keep "samsung,exynos5-gsc" compatible, and add Exynos 5250/5420/5433 compatible. Best regards, Hoegeun