Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751825AbdIMJpX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Sep 2017 05:45:23 -0400
Received: from mx2.suse.de ([195.135.220.15]:41632 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751317AbdIMJpW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Sep 2017 05:45:22 -0400
Subject: Re: [Xen-devel] [PATCH v9 10/12] x86/xen: Bypass intr mode setup in
 enlighten_pv system
To: Dou Liyang <douly.fnst@cn.fujitsu.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc: bhe@redhat.com, boris.ostrovsky@oracle.com, hpa@zytor.com,
        xen-devel@lists.xenproject.org, tglx@linutronix.de, yinghai@kernel.org,
        mingo@kernel.org
References: <1505293975-26005-1-git-send-email-douly.fnst@cn.fujitsu.com>
 <1505293975-26005-11-git-send-email-douly.fnst@cn.fujitsu.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <ecef9d1c-1f35-9bff-0661-4dc9ef08d835@suse.com>
Date: Wed, 13 Sep 2017 11:45:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1505293975-26005-11-git-send-email-douly.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1623
Lines: 50

On 13/09/17 11:12, Dou Liyang wrote:
> XEN PV overrides smp_prepare_cpus(). xen_pv_smp_prepare_cpus()
> initializes interrupts in the XEN PV specific way and does not invoke
> native_smp_prepare_cpus(). As a consequence, x86_init.intr_mode_init() is
> not invoked either.
> 
> The invocation of x86_init.intr_mode_init() will be moved from
> native_smp_prepare_cpus() in a follow up patch to solve <INSERT
> REASON/PROBLEM>.

I asked you to be more specific here before. So: what will be solved?
Can I select a problem I like? ;-)

> That move would cause the invocation of x86_init.intr_mode_init() for XEN
> PV platforms. To prevent that, override the default x86_init.intr_mode_init()
> callback with a noop().
> 
> [Rewrited by Thomas Gleixner <tglx@linutronix.de>]

Rewritten?

> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
> Cc: xen-devel@lists.xenproject.org
> Cc: boris.ostrovsky@oracle.com
> Cc: Juergen Gross <jgross@suse.com>

Regarding the changes below:

Acked-by: Juergen Gross <jgross@suse.com>


Juergen

> ---
>  arch/x86/xen/enlighten_pv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> index ae2a2e2..934dc7f 100644
> --- a/arch/x86/xen/enlighten_pv.c
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -1232,6 +1232,7 @@ asmlinkage __visible void __init xen_start_kernel(void)
>  	x86_platform.get_nmi_reason = xen_get_nmi_reason;
>  
>  	x86_init.resources.memory_setup = xen_memory_setup;
> +	x86_init.irqs.intr_mode_init	= x86_init_noop;
>  	x86_init.oem.arch_setup = xen_arch_setup;
>  	x86_init.oem.banner = xen_banner;
>  
>