Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752075AbdIMKJe (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Sep 2017 06:09:34 -0400
Received: from mail.cn.fujitsu.com ([183.91.158.132]:58039 "EHLO
        heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1751444AbdIMKJb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Sep 2017 06:09:31 -0400
X-IronPort-AV: E=Sophos;i="5.42,387,1500912000"; 
   d="scan'208";a="26086409"
Subject: Re: [Xen-devel] [PATCH v9 10/12] x86/xen: Bypass intr mode setup in
 enlighten_pv system
To: Juergen Gross <jgross@suse.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1505293975-26005-1-git-send-email-douly.fnst@cn.fujitsu.com>
 <1505293975-26005-11-git-send-email-douly.fnst@cn.fujitsu.com>
 <ecef9d1c-1f35-9bff-0661-4dc9ef08d835@suse.com>
CC: <bhe@redhat.com>, <boris.ostrovsky@oracle.com>, <hpa@zytor.com>,
        <xen-devel@lists.xenproject.org>, <tglx@linutronix.de>,
        <yinghai@kernel.org>, <mingo@kernel.org>
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <e3bdc29b-1e89-a1d1-487c-a1f31776b746@cn.fujitsu.com>
Date: Wed, 13 Sep 2017 18:09:24 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <ecef9d1c-1f35-9bff-0661-4dc9ef08d835@suse.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.167.226.106]
X-yoursite-MailScanner-ID: 3899047CA46F.AB052
X-yoursite-MailScanner: Found to be clean
X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1980
Lines: 72

Hi Juergen,

At 09/13/2017 05:45 PM, Juergen Gross wrote:
> On 13/09/17 11:12, Dou Liyang wrote:
>> XEN PV overrides smp_prepare_cpus(). xen_pv_smp_prepare_cpus()
>> initializes interrupts in the XEN PV specific way and does not invoke
>> native_smp_prepare_cpus(). As a consequence, x86_init.intr_mode_init() is
>> not invoked either.
>>
>> The invocation of x86_init.intr_mode_init() will be moved from
>> native_smp_prepare_cpus() in a follow up patch to solve <INSERT
>> REASON/PROBLEM>.
>
> I asked you to be more specific here before. So: what will be solved?
> Can I select a problem I like? ;-)

Oops, I am sorry I missed it. I will modify it.

...to solve the dump-capture kernel hangs, if there is a notsc option
in its command line.

>
>> That move would cause the invocation of x86_init.intr_mode_init() for XEN
>> PV platforms. To prevent that, override the default x86_init.intr_mode_init()
>> callback with a noop().
>>
>> [Rewrited by Thomas Gleixner <tglx@linutronix.de>]
>
> Rewritten?

Yeah, yeah. poor english skill :-).

>
>> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
>> Cc: xen-devel@lists.xenproject.org
>> Cc: boris.ostrovsky@oracle.com
>> Cc: Juergen Gross <jgross@suse.com>
>
> Regarding the changes below:
>
> Acked-by: Juergen Gross <jgross@suse.com>
>

Thank you for your acked, I will re-post it.

Thanks,
	dou.
>
> Juergen
>
>> ---
>>  arch/x86/xen/enlighten_pv.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
>> index ae2a2e2..934dc7f 100644
>> --- a/arch/x86/xen/enlighten_pv.c
>> +++ b/arch/x86/xen/enlighten_pv.c
>> @@ -1232,6 +1232,7 @@ asmlinkage __visible void __init xen_start_kernel(void)
>>  	x86_platform.get_nmi_reason = xen_get_nmi_reason;
>>
>>  	x86_init.resources.memory_setup = xen_memory_setup;
>> +	x86_init.irqs.intr_mode_init	= x86_init_noop;
>>  	x86_init.oem.arch_setup = xen_arch_setup;
>>  	x86_init.oem.banner = xen_banner;
>>
>>
>
>
>
>