Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752244AbdIMNSi (ORCPT ); Wed, 13 Sep 2017 09:18:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:43984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbdIMNSe (ORCPT ); Wed, 13 Sep 2017 09:18:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83A2721BB7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org X-Google-Smtp-Source: AOwi7QAzUILoERVj7ZER6J5ltvxjsHVMtYiNLWrUlD+f6mRTn+1HWUnstIpA6UdjdszJ86RokdHR24KIg17nnU8tbZs= MIME-Version: 1.0 In-Reply-To: <51b3b386-22c0-7663-6f54-d166ebebd332@partner.samsung.com> References: <51b3b386-22c0-7663-6f54-d166ebebd332@partner.samsung.com> From: Krzysztof Kozlowski Date: Wed, 13 Sep 2017 15:18:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] crypto: s5p-sss: Add HASH support for Exynos To: Kamil Konieczny Cc: linux-crypto@vger.kernel.org, Herbert Xu , Vladimir Zapolskiy , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1627 Lines: 47 On Wed, Sep 13, 2017 at 2:44 PM, Kamil Konieczny wrote: > Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. > It uses the crypto framework asynchronous hash api. > It is based on omap-sham.c driver. > S5P has some HW differencies and is not implemented. > > Modifications in s5p-sss: > > - Add hash supporting structures and functions. > > - Modify irq handler to handle both aes and hash signals. > > - Disable HASH in probe if Exynos PRNG is enabled. > > - Add new copyright line and new author. > > - Tested on Odroid-U3 with Exynos 4412 CPU, kernel 4.13-rc6 > with crypto run-time self test testmgr > and with tcrypt module with: modprobe tcrypt sec=1 mode=N > where N=402, 403, 404 (MD5, SHA1, SHA256). > > Modifications in drivers/crypto/Kconfig: > > - Select sw algorithms MD5, SHA1 and SHA256 in S5P > as they are nedded for fallback. > > Signed-off-by: Kamil Konieczny > --- > drivers/crypto/Kconfig | 6 + > drivers/crypto/s5p-sss.c | 2062 +++++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 1939 insertions(+), 129 deletions(-) > Nice work, thanks! You need to split the patch, it is just too huge making it very difficult to review. Please split it per logically sensible improvements. I see some cleanups mixed with new features - this definitely must be split out. This looks more or less like an early work or RFC... because I see things like "#if 0", "HACK" or "CONFIG_....". If so, ask the question about your problems directly. Do not force readers to find them out... Best regards, Krzysztof