Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751466AbdIMNp1 (ORCPT ); Wed, 13 Sep 2017 09:45:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:44301 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751330AbdIMNpV (ORCPT ); Wed, 13 Sep 2017 09:45:21 -0400 Date: Wed, 13 Sep 2017 06:45:18 -0700 (PDT) From: Jiri Kosina X-X-Sender: jkosina@wotan.suse.de To: Joe Lawrence cc: Josh Poimboeuf , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu , Miroslav Benes , Petr Mladek Subject: Re: [PATCH v6] livepatch: introduce shadow variable API In-Reply-To: Message-ID: References: <1504211861-19899-1-git-send-email-joe.lawrence@redhat.com> <1504211861-19899-2-git-send-email-joe.lawrence@redhat.com> <20170912162034.lmpkjjefg3ft4m7r@treble> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 36 On Tue, 12 Sep 2017, Joe Lawrence wrote: > > On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote: > >> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data, > >> + size_t size, gfp_t gfp_flags, bool warn_on_exist) > >> +{ > >> + struct klp_shadow *new_shadow; > >> + void *shadow_data; > >> + unsigned long flags; > >> + > >> + /* Check if the shadow variable if already exists */ > > > > Grammar fix: either > > > > s/if the shadow variable// > > > > or > > > > s/if // > > > > Otherwise: > > > > Acked-by: Josh Poimboeuf > > > > If this is the only outstanding nit, can this be fixed up on merge or > does it need a new patch spin? No need to resend just because of this, I'll fix this up manually once applying. Thanks, -- Jiri Kosina SUSE Labs