Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbdIMOKc (ORCPT ); Wed, 13 Sep 2017 10:10:32 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:32914 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbdIMOK2 (ORCPT ); Wed, 13 Sep 2017 10:10:28 -0400 X-Google-Smtp-Source: AOwi7QC/+Q/e/zUnx/8s9zNxv20cYAkFiY8I4WVPUK70g04MT8+CQZb3HW9SKCHOUXiQybp0VbkFRQ== Date: Wed, 13 Sep 2017 09:10:26 -0500 From: Rob Herring To: Chaotian Jing Cc: Ulf Hansson , Mark Rutland , Matthias Brugger , Catalin Marinas , Will Deacon , yong mao , Linus Walleij , Javier Martinez Canillas , Heiner Kallweit , Phong LE , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [PATCH 01/12] mmc: dt-bindings: update Mediatek MMC bindings Message-ID: <20170913141026.43oh4n4foipmahsk@rob-hp-laptop> References: <1505207272-16983-1-git-send-email-chaotian.jing@mediatek.com> <1505207272-16983-2-git-send-email-chaotian.jing@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505207272-16983-2-git-send-email-chaotian.jing@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2436 Lines: 57 On Tue, Sep 12, 2017 at 05:07:41PM +0800, Chaotian Jing wrote: > Change the comptiable for support of multi-platform > Add description for reg > Add description for source_cg > Add description for mediatek,latch-ck This is at least the 3rd patch with exactly the same vague subject. Please make the subject somewhat unique. > > Signed-off-by: Chaotian Jing > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 4182ea3..405cd06 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -7,10 +7,15 @@ This file documents differences between the core properties in mmc.txt > and the properties used by the msdc driver. > > Required properties: > -- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc" > +- compatible: value should be either of the following. > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > + "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > + "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > +- reg: physical base address of the controller and length > - interrupts: Should contain MSDC interrupt number > -- clocks: MSDC source clock, HCLK > -- clock-names: "source", "hclk" > +- clocks: MSDC source clock, HCLK, source_cg > +- clock-names: "source", "hclk", "source_cg" All chips support source_cg? That's not backwards compatible for existing compatible strings if the driver requires it. > - pinctrl-names: should be "default", "state_uhs" > - pinctrl-0: should contain default/high speed pin ctrl > - pinctrl-1: should contain uhs mode pin ctrl > @@ -30,6 +35,8 @@ Optional properties: > - mediatek,hs400-cmd-resp-sel-rising: HS400 command response sample selection > If present,HS400 command responses are sampled on rising edges. > If not present,HS400 command responses are sampled on falling edges. > +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc What's a project? > + error caused by stop clock(fifo full) > > Examples: > mmc0: mmc@11230000 { > -- > 1.8.1.1.dirty >