Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087AbdIMOw0 (ORCPT ); Wed, 13 Sep 2017 10:52:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:49911 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751686AbdIMOwW (ORCPT ); Wed, 13 Sep 2017 10:52:22 -0400 Date: Wed, 13 Sep 2017 07:52:20 -0700 (PDT) From: Jiri Kosina X-X-Sender: jkosina@wotan.suse.de To: Dmitry Torokhov cc: Benjamin Tissoires , Guenter Roeck , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case In-Reply-To: <20170913144950.GA1122@dtor-ws> Message-ID: References: <20170908175527.GA19720@dtor-ws> <20170913144950.GA1122@dtor-ws> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 34 On Wed, 13 Sep 2017, Dmitry Torokhov wrote: > > > From: Adrian Salido > > > > > > The buffer allocation is not currently accounting for an extra byte for > > > the report id. This can cause an out of bounds access in function > > > i2c_hid_set_or_send_report() with reportID > 15. > > > > > > Signed-off-by: Guenter Roeck > > > Signed-off-by: Dmitry Torokhov > > > > Missing signoff from the patch author? > > Oops, I must have cut it off on accident while removing ChromeOS > specific tags, the original commit is here: > > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212 Ok, thanks, will use that one. How about Reviewed-by: Benson Leung which is missing in the mail you've sent, but is there in the above reference commit? > > Also, I think this should have Cc: stable, right? > > I usually let maintainers decide, but yes. I'll be adding it. Thanks, -- Jiri Kosina SUSE Labs