Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751807AbdIMPiX (ORCPT ); Wed, 13 Sep 2017 11:38:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:52450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbdIMPiW (ORCPT ); Wed, 13 Sep 2017 11:38:22 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2C442133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 13 Sep 2017 12:38:19 -0300 From: Arnaldo Carvalho de Melo To: "Liang, Kan" Cc: "peterz@infradead.org" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "jolsa@kernel.org" , "namhyung@kernel.org" , "Hunter, Adrian" , "Odzioba, Lukasz" , "ak@linux.intel.com" Subject: Re: [PATCH RFC V2 00/10] perf top optimization Message-ID: <20170913153819.GL5866@kernel.org> References: <1505096603-215017-1-git-send-email-kan.liang@intel.com> <20170913152506.GK5866@kernel.org> <37D7C6CF3E00A74B8858931C1DB2F077537AF31A@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077537AF31A@SHSMSX103.ccr.corp.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2741 Lines: 69 Em Wed, Sep 13, 2017 at 03:29:44PM +0000, Liang, Kan escreveu: > > > > Em Sun, Sep 10, 2017 at 07:23:13PM -0700, kan.liang@intel.com escreveu: > > > > So I got the first two patches already merged, and made some comments > > about the other patches, please check those, > > > > Thanks for the review Arnaldo. > > I will take a close look for the comments. > For the next version, I only need to include patch 3-10, correct? Right, and go from my perf/core branch. The hashtable patch is still not there as I am running tests before pushing out, but it should be there later today. Thanks! - Arnaldo > > Thanks, > Kan > > > Thanks, > > > > - Arnaldo > > > > > Changes since V1: > > > - Patch 1: machine threads and hashtable related renaming (Arnaldo) > > > - Patch 6: use a smaller locked section for comm_str__put > > > add a locked wrapper for comm_str__findnew (Arnaldo) > > > > > > Kan Liang (10): > > > perf tools: hashtable for machine threads > > > perf tools: using scandir to replace readdir > > > petf tools: using comm_str to replace comm in hist_entry > > > petf tools: introduce a new function to set namespaces id > > > perf tools: lock to protect thread list > > > perf tools: lock to protect comm_str rb tree > > > perf tools: change machine comm_exec type to atomic > > > perf top: implement multithreading for perf_event__synthesize_threads > > > perf top: add option to set the number of thread for event synthesize > > > perf top: switch back to overwrite mode > > > > > > tools/perf/builtin-kvm.c | 3 +- > > > tools/perf/builtin-record.c | 2 +- > > > tools/perf/builtin-top.c | 9 +- > > > tools/perf/builtin-trace.c | 21 +++-- > > > tools/perf/tests/mmap-thread-lookup.c | 2 +- > > > tools/perf/ui/browsers/hists.c | 2 +- > > > tools/perf/util/comm.c | 18 +++- > > > tools/perf/util/event.c | 149 +++++++++++++++++++++++++------- > > > tools/perf/util/event.h | 14 ++- > > > tools/perf/util/evlist.c | 5 +- > > > tools/perf/util/hist.c | 11 +-- > > > tools/perf/util/machine.c | 158 +++++++++++++++++++++------------- > > > tools/perf/util/machine.h | 34 ++++++-- > > > tools/perf/util/rb_resort.h | 5 +- > > > tools/perf/util/sort.c | 8 +- > > > tools/perf/util/sort.h | 2 +- > > > tools/perf/util/thread.c | 68 ++++++++++++--- > > > tools/perf/util/thread.h | 6 +- > > > tools/perf/util/top.h | 1 + > > > 19 files changed, 376 insertions(+), 142 deletions(-) > > > > > > -- > > > 2.5.5