Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751479AbdIMSOf (ORCPT ); Wed, 13 Sep 2017 14:14:35 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:46480 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbdIMSOd (ORCPT ); Wed, 13 Sep 2017 14:14:33 -0400 Date: Wed, 13 Sep 2017 12:14:21 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , open list Subject: Re: [PATCH 1/3] tpm: fix type of a local variable in tpm2_get_cc_attrs_tbl() Message-ID: <20170913181421.GA1536@obsidianresearch.com> References: <20170913172620.24829-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170913172620.24829-1-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 360 Lines: 11 On Wed, Sep 13, 2017 at 10:26:20AM -0700, Jarkko Sakkinen wrote: > The local variable 'attrs' should have the type __be32 instead of u32. > > Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands") > Signed-off-by: Jarkko Sakkinen All 3 look good to me: Reviewed-by: Jason Gunthorpe Jason