Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751962AbdIMSwU (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Sep 2017 14:52:20 -0400
Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51667 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751881AbdIMSwR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Sep 2017 14:52:17 -0400
Subject: Re: [tpmdd-devel] [PATCH v2 1/4] tpm: ignore burstcount to improve
 tpm_tis send() performance.
Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org,
        tpmdd-devel@lists.sourceforge.net,
        linux-ima-devel@lists.sourceforge.net
References: <20170906125643.5070-1-nayna@linux.vnet.ibm.com>
 <20170906125643.5070-2-nayna@linux.vnet.ibm.com>
 <20170906161246.GA9747@obsidianresearch.com>
From: Ken Goldman <kgold@linux.vnet.ibm.com>
Date: Wed, 13 Sep 2017 14:52:12 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170906161246.GA9747@obsidianresearch.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-TM-AS-GCONF: 00
x-cbid: 17091318-0040-0000-0000-000003A14A91
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00007722; HX=3.00000241; KW=3.00000007;
 PH=3.00000004; SC=3.00000227; SDB=6.00916541; UDB=6.00460262; IPR=6.00696772;
 BA=6.00005588; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000;
 ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017140; XFM=3.00000015;
 UTC=2017-09-13 18:52:14
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 17091318-0041-0000-0000-000007964C4B
Message-Id: <3c418974-a4c7-518e-b218-f6373c10209e@linux.vnet.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-13_06:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000
 definitions=main-1709130289
To: unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 489
Lines: 16

On 9/6/2017 12:12 PM, Jason Gunthorpe wrote:
> 
> The problem with this approach is that the TPM could totally block
> the CPU for very long periods of time.
> 
> It seems very risky to enable..
> 

How would you characterize "very long"?

The TPM vendors confirm that they empty the FIFO at internal speeds that
are comparable to the bus speed.  Thus, any stall will be sub-usec.  Is
that an issue?

In addition, new TPMs have ever larger FIFO's, making stalls less likely
going forward.