Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752180AbdIMTqK (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Sep 2017 15:46:10 -0400
Received: from mail-io0-f196.google.com ([209.85.223.196]:34181 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752120AbdIMTqD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Sep 2017 15:46:03 -0400
X-Google-Smtp-Source: AOwi7QCJJllW990lbN9Z8+VwxmaMM/ZPs6oRHbks18QIau3h2ClRw4wQwFrw5Fot4kflKhue6uHopw==
Date: Wed, 13 Sep 2017 15:47:50 -0400
From: Chuck Ebbert <cebbert.lkml@gmail.com>
To: Josef Bacik <jbacik@fb.com>
Cc: Laura Abbott <labbott@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        "Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Cole Robinson <crobinso@redhat.com>
Subject: Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly")
 causes bind port regression
Message-ID: <20170913154750.100881c0@gmail.com>
In-Reply-To: <EF55EF02-AD40-4F06-8C07-4F9F4221BFE6@fb.com>
References: <1a8ef376-387e-e0fc-7362-e1fd2c2c45d3@redhat.com>
        <AF16C126-99CA-401A-B803-AA05CDFBFF93@fb.com>
        <588f3795-931e-7779-4ec7-5fe7d4437927@redhat.com>
        <EF55EF02-AD40-4F06-8C07-4F9F4221BFE6@fb.com>
Organization: Very little
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8DJkDYS024353
Content-Length: 1461
Lines: 42

On Wed, 13 Sep 2017 17:28:25 +0000
Josef Bacik <jbacik@fb.com> wrote:

> Sorry I thought I had made this other fix, can you apply this on top
> of the other one and try that?  I have more things to try if this
> doesn’t work, sorry you are playing go between, but I want to make
> sure I know _which_ fix actually fixes the problem, and then clean up
> in followup patches.  Thanks,
> 
> Josef
> 
> On 9/13/17, 8:45 AM, "Laura Abbott" <labbott@redhat.com> wrote:
> 
> On 09/12/2017 04:12 PM, Josef Bacik wrote:
> > First I’m super sorry for the top post, I’m at plumbers and I
> > forgot to upload my muttrc to my new cloud instance, so I’m screwed
> > using outlook.
> > 
> > I have a completely untested, uncompiled patch that I think will
> > fix the problem, would you mind giving it a go?  Thanks,
> > 
> > Josef  
> 
> Thanks for the quick turnaround. Unfortunately, the problem is still
> reproducible according to the reporter.
> 
> Thanks,
> Laura

I am confused by the patch that originally caused this:

        if (sk->sk_family == AF_INET6)
                return ipv6_rcv_saddr_equal(&sk->sk_v6_rcv_saddr,
-                                           &sk2->sk_v6_rcv_saddr,
+                                           inet6_rcv_saddr(sk2),
                                            sk->sk_rcv_saddr,
                                            sk2->sk_rcv_saddr,

Shouldn't the first argument also be changed to use inet6_rcv_saddr()?