Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751502AbdIMUee (ORCPT ); Wed, 13 Sep 2017 16:34:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55454 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdIMUeb (ORCPT ); Wed, 13 Sep 2017 16:34:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CE5DFC04B94B Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH] KVM: VMX: require virtual NMI support To: Zdenek Kaspar , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: rkrcmar@redhat.com References: <1490618297-10581-2-git-send-email-pbonzini@redhat.com> <37c3939f-6c5e-1f88-5642-a5efb3ece1c4@gmail.com> From: Paolo Bonzini Message-ID: <16056526-1fc8-4ad8-5308-c16110d12e88@redhat.com> Date: Wed, 13 Sep 2017 22:34:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <37c3939f-6c5e-1f88-5642-a5efb3ece1c4@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 13 Sep 2017 20:34:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 636 Lines: 17 On 13/09/2017 19:23, Zdenek Kaspar wrote: > On 03/27/2017 02:38 PM, Paolo Bonzini wrote: >> Virtual NMIs are only missing in Prescott and Yonah chips. Both are obsolete >> for virtualization usage---Yonah is 32-bit only even---so drop vNMI emulation. >> >> Signed-off-by: Paolo Bonzini >> --- >> arch/x86/kvm/vmx.c | 143 ++++++++++++++--------------------------------------- >> 1 file changed, 38 insertions(+), 105 deletions(-) > > This breaks virtualization on old Intel Core2 machines. > Any chance to revert? Already planned for 4.14 and future 4.13 stable kernels, but haven't gotten round to it. Paolo