Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751496AbdIMVcH (ORCPT ); Wed, 13 Sep 2017 17:32:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38066 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdIMVcC (ORCPT ); Wed, 13 Sep 2017 17:32:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8DE2881DFF Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH] KVM: SVM: Do not issue virtual VMLOAD/VMSAVE supported-message To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Borislav Petkov Cc: KVM , LKML , Janakarajan Natarajan References: <20170905170628.10211-1-bp@alien8.de> <20170913140608.GA2673@flask> From: Paolo Bonzini Message-ID: <134ece61-01aa-2720-98e9-9b9817125af8@redhat.com> Date: Wed, 13 Sep 2017 23:31:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170913140608.GA2673@flask> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 13 Sep 2017 21:32:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 477 Lines: 17 On 13/09/2017 16:06, Radim Krčmář wrote: > - } > + if (!boot_cpu_has(X86_FEATURE_VGIF)) > + vgif = false; > + > + pr_info("SVM nested=%d npt=%d avic=%d vls=%d vgif=%d\n", > + nested, npt_enabled, avic, vls, vgif); I doubt we'd get the above info message more than sporadically, and all these are available with a simple grep -r . /sys/module/kvm_amd/parameters which we already do routinely ask bug reporters for the equivalent kvm_intel. So I'd say, zap it. Paolo