Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751500AbdIMXEi (ORCPT ); Wed, 13 Sep 2017 19:04:38 -0400 Received: from mga04.intel.com ([192.55.52.120]:36644 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbdIMXEg (ORCPT ); Wed, 13 Sep 2017 19:04:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,390,1500966000"; d="scan'208";a="151054163" Date: Wed, 13 Sep 2017 16:04:25 -0700 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , open list Subject: Re: [PATCH 1/3] tpm: fix type of a local variable in tpm2_get_cc_attrs_tbl() Message-ID: <20170913230425.xmgnrdz2nazxnvbr@linux.intel.com> References: <20170913172620.24829-1-jarkko.sakkinen@linux.intel.com> <20170913181421.GA1536@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170913181421.GA1536@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 465 Lines: 16 On Wed, Sep 13, 2017 at 12:14:21PM -0600, Jason Gunthorpe wrote: > On Wed, Sep 13, 2017 at 10:26:20AM -0700, Jarkko Sakkinen wrote: > > The local variable 'attrs' should have the type __be32 instead of u32. > > > > Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands") > > Signed-off-by: Jarkko Sakkinen > > All 3 look good to me: > > Reviewed-by: Jason Gunthorpe > > Jason Thanks! /Jarkko