Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbdIMXdh (ORCPT ); Wed, 13 Sep 2017 19:33:37 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:44555 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdIMXdd (ORCPT ); Wed, 13 Sep 2017 19:33:33 -0400 X-Google-Smtp-Source: AOwi7QCTomxDvHNBjKOqJzh0Kfs06lg5/9qDnw+8Q1a5+cr2lS/uZltQ0ze95gXf44Eu8xPD2l316DdfJFp/WtQPNqc= MIME-Version: 1.0 In-Reply-To: <20170913161501.7356-1-colin.king@canonical.com> References: <20170913161501.7356-1-colin.king@canonical.com> From: Daniel Drake Date: Thu, 14 Sep 2017 07:33:31 +0800 Message-ID: Subject: Re: [PATCH][pinctrl-next] pinctrl/amd: make functions amd_gpio_suspend and amd_gpio_resume static To: Colin King Cc: Linus Walleij , linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org, Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 545 Lines: 14 On Thu, Sep 14, 2017 at 12:15 AM, Colin King wrote: > > From: Colin Ian King > > The functions amd_gpio_suspend and amd_gpio_resume are local to the > source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'amd_gpio_suspend' was not declared. Should it be static? > symbol 'amd_gpio_resume' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Reviewed-by: Daniel Drake