Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751369AbdINBo7 (ORCPT ); Wed, 13 Sep 2017 21:44:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59234 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbdINBo4 (ORCPT ); Wed, 13 Sep 2017 21:44:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 71640C0587DD Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=bhe@redhat.com Date: Thu, 14 Sep 2017 09:44:51 +0800 From: Baoquan He To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, thgarnie@google.com, keescook@chromium.org, akpm@linux-foundation.org, yamada.masahiro@socionext.com, rja@hpe.com, frank.ramsay@hpe.com Subject: Re: [PATCH v2 RESEND 0/2] x86/mm/KASLR: Do not adapt the size of the direct mapping section for SGI UV system Message-ID: <20170914014451.GK12824@x1> References: <1504770150-25456-1-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504770150-25456-1-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 14 Sep 2017 01:44:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1889 Lines: 51 Hi all, PING! Do anyone has any suggestion about this issue? This bug blocks SGI system's boot, KASLR has to be disabled on SGI system if they want to run tests. Thanks Baoquan On 09/07/17 at 03:42pm, Baoquan He wrote: > This is v2 post RESEND. Add Mike's Acked-by to patch 2/2 as he suggested > in private mail. And update patches log slightly. > > This patchset is trying to fix a bug that SGI UV system casually hang > during boot with KASLR enabled. The root cause is that mm KASLR adapts > size of the direct mapping section only based on the system RAM size. > Then later when map SGI UV MMIOH region into the direct mapping during > rest_init() invocation, it might go beyond of the directing mapping > section and step into VMALLOC or VMEMMAP area, then BUG_ON triggered. > > The fix is adding a helper function is_early_uv_system to check UV system > earlier, then call the helper function in kernel_randomize_memory() to > check if it's a SGI UV system, if yes, we keep the size of direct mapping > section to be 64TB just as nokslr. > > With this fix, SGI UV system can have 64TB direct mapping size always, > and the starting address of direct mapping/vmalloc/vmemmap and the padding > between them can still be randomized to enhance the system security. > > v1->v2: > 1. Mike suggested making is_early_uv_system() an inline function and be > put in include/asm/uv/uv.h so that they can adjust them easier in the > future. > > 2. Split the v1 code into uv part and mm KASLR part as Mike suggested. > > Baoquan He (2): > x86/UV: Introduce a helper function to check UV system at earlier > stage > x86/mm/KASLR: Do not adapt the size of the direct mapping section for > SGI UV system > > arch/x86/include/asm/uv/uv.h | 6 ++++++ > arch/x86/mm/kaslr.c | 3 ++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > -- > 2.5.5 >