Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751421AbdINCKg (ORCPT ); Wed, 13 Sep 2017 22:10:36 -0400 Received: from mailgw01.mediatek.com ([218.249.47.110]:51088 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751311AbdINCKd (ORCPT ); Wed, 13 Sep 2017 22:10:33 -0400 X-UUID: d8a1b34d82534fa1990df562c928cc56-20170914 Message-ID: <1505355021.8308.4.camel@mhfsdcap03> Subject: Re: [PATCH 01/12] mmc: dt-bindings: update Mediatek MMC bindings From: Chaotian Jing To: Rob Herring CC: Ulf Hansson , Mark Rutland , Matthias Brugger , "Catalin Marinas" , Will Deacon , "yong mao" , Linus Walleij , Javier Martinez Canillas , Heiner Kallweit , Phong LE , , , , , , Date: Thu, 14 Sep 2017 10:10:21 +0800 In-Reply-To: <20170913141026.43oh4n4foipmahsk@rob-hp-laptop> References: <1505207272-16983-1-git-send-email-chaotian.jing@mediatek.com> <1505207272-16983-2-git-send-email-chaotian.jing@mediatek.com> <20170913141026.43oh4n4foipmahsk@rob-hp-laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2825 Lines: 64 On Wed, 2017-09-13 at 09:10 -0500, Rob Herring wrote: > On Tue, Sep 12, 2017 at 05:07:41PM +0800, Chaotian Jing wrote: > > Change the comptiable for support of multi-platform > > Add description for reg > > Add description for source_cg > > Add description for mediatek,latch-ck > > This is at least the 3rd patch with exactly the same vague subject. > Please make the subject somewhat unique. > Thx, will change the subject at next version > > > > Signed-off-by: Chaotian Jing > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 4182ea3..405cd06 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -7,10 +7,15 @@ This file documents differences between the core properties in mmc.txt > > and the properties used by the msdc driver. > > > > Required properties: > > -- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc" > > +- compatible: value should be either of the following. > > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > > + "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > > + "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > > +- reg: physical base address of the controller and length > > - interrupts: Should contain MSDC interrupt number > > -- clocks: MSDC source clock, HCLK > > -- clock-names: "source", "hclk" > > +- clocks: MSDC source clock, HCLK, source_cg > > +- clock-names: "source", "hclk", "source_cg" > > All chips support source_cg? That's not backwards compatible for > existing compatible strings if the driver requires it. Not all chips support source_cg, for chips which do not support source_cg, no need source_cg here, and the driver will parse it to know if current chip support it. > > > - pinctrl-names: should be "default", "state_uhs" > > - pinctrl-0: should contain default/high speed pin ctrl > > - pinctrl-1: should contain uhs mode pin ctrl > > @@ -30,6 +35,8 @@ Optional properties: > > - mediatek,hs400-cmd-resp-sel-rising: HS400 command response sample selection > > If present,HS400 command responses are sampled on rising edges. > > If not present,HS400 command responses are sampled on falling edges. > > +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc > > What's a project? eg, MT2701 > > > + error caused by stop clock(fifo full) > > > > Examples: > > mmc0: mmc@11230000 { > > -- > > 1.8.1.1.dirty > >