Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751419AbdINFPs (ORCPT ); Thu, 14 Sep 2017 01:15:48 -0400 Received: from sender-pp-091.zoho.com ([135.84.80.236]:25149 "EHLO sender-pp-091.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdINFPq (ORCPT ); Thu, 14 Sep 2017 01:15:46 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=cc:to:from:subject:message-id:date:user-agent:mime-version:content-type; b=iWX30MEFeliTxYa6znGloQrDMydcw7am/uH4JfcH9XNDKWpcV8t3T4LfYLIYw5Y6bX532XhcvsUg jYQbsPn62Hjkxj04ojkJAS+h9QE0GsvWQj1EqagH3+C+GO3NBmG2 Cc: linux-kernel@vger.kernel.org, zijun_hu@htc.com To: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, james.morse@arm.com, sudeep.holla@arm.com From: zijun_hu Subject: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu() Message-ID: <59BA1062.1010406@zoho.com> Date: Thu, 14 Sep 2017 13:15:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1083 Lines: 41 From: zijun_hu get_cpu_number() doesn't use existing helper to iterate over possible CPUs, so error happens in case of discontinuous @cpu_possible_mask such as 0b11110001. fixed by using existing helper for_each_possible_cpu(). Signed-off-by: zijun_hu --- drivers/irqchip/irq-gic-v3.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 19d642eae096..2a0427c2971e 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -990,7 +990,7 @@ static int get_cpu_number(struct device_node *dn) { const __be32 *cell; u64 hwid; - int i; + int cpu; cell = of_get_property(dn, "reg", NULL); if (!cell) @@ -1004,9 +1004,9 @@ static int get_cpu_number(struct device_node *dn) if (hwid & ~MPIDR_HWID_BITMASK) return -1; - for (i = 0; i < num_possible_cpus(); i++) - if (cpu_logical_map(i) == hwid) - return i; + for_each_possible_cpu(cpu) + if (cpu_logical_map(cpu) == hwid) + return cpu; return -1; } -- 1.9.1