Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751338AbdINF7a (ORCPT ); Thu, 14 Sep 2017 01:59:30 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:45925 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdINF73 (ORCPT ); Thu, 14 Sep 2017 01:59:29 -0400 X-IronPort-AV: E=Sophos;i="5.42,391,1500933600"; d="scan'208";a="237422386" Date: Thu, 14 Sep 2017 07:59:26 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Haneen Mohammed cc: outreachy-kernel , Samuel Ortiz , Greg Kroah-Hartman , netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: irda: Remove typedef struct In-Reply-To: <20170914045538.GA24121@Haneen> Message-ID: References: <20170914045538.GA24121@Haneen> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2473 Lines: 99 On Wed, 13 Sep 2017, Haneen Mohammed wrote: > This patch remove typedef from a structure with all its ocurrences > since using typedefs for structures is discouraged. > Issue found using Coccinelle: > > @r1@ > type T; > @@ > > typedef struct { ... } T; > > @script:python c1@ > T2; > T << r1.T; > @@ > if T[-2:] =="_t" or T[-2:] == "_T": > coccinelle.T2 = T[:-2]; > else: > coccinelle.T2 = T; > > print T, coccinelle.T2 > > @r2@ > type r1.T; > identifier c1.T2; > @@ > -typedef > struct > + T2 > { ... } > -T > ; > > @r3@ > type r1.T; > identifier c1.T2; > @@ > -T > +struct T2 > > Signed-off-by: Haneen Mohammed Acked-by: Julia Lawall > --- > drivers/staging/irda/include/net/irda/qos.h | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/irda/include/net/irda/qos.h b/drivers/staging/irda/include/net/irda/qos.h > index 05a5a24..a0315b5 100644 > --- a/drivers/staging/irda/include/net/irda/qos.h > +++ b/drivers/staging/irda/include/net/irda/qos.h > @@ -58,23 +58,23 @@ > #define IR_16000000 0x02 > > /* Quality of Service information */ > -typedef struct { > +struct qos_value { > __u32 value; > __u16 bits; /* LSB is first byte, MSB is second byte */ > -} qos_value_t; > +}; > > struct qos_info { > magic_t magic; > > - qos_value_t baud_rate; /* IR_11520O | ... */ > - qos_value_t max_turn_time; > - qos_value_t data_size; > - qos_value_t window_size; > - qos_value_t additional_bofs; > - qos_value_t min_turn_time; > - qos_value_t link_disc_time; > + struct qos_value baud_rate; /* IR_11520O | ... */ > + struct qos_value max_turn_time; > + struct qos_value data_size; > + struct qos_value window_size; > + struct qos_value additional_bofs; > + struct qos_value min_turn_time; > + struct qos_value link_disc_time; > > - qos_value_t power; > + struct qos_value power; > }; > > extern int sysctl_max_baud_rate; > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170914045538.GA24121%40Haneen. > For more options, visit https://groups.google.com/d/optout. >