Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbdINGQ7 (ORCPT ); Thu, 14 Sep 2017 02:16:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41050 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbdINGQ6 (ORCPT ); Thu, 14 Sep 2017 02:16:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6E791C04B303 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=shuwang@redhat.com From: shuwang@redhat.com To: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, liwang@redhat.com, chuhu@redhat.com, Shu Wang Subject: [PATCH] megaraid: kmemleak: Track page allocation for fusion Date: Thu, 14 Sep 2017 14:16:46 +0800 Message-Id: <20170914061646.10275-1-shuwang@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 14 Sep 2017 06:16:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2221 Lines: 71 From: Shu Wang Kmemleak reports about a thousand false positives for fusion-> cmd_list[]. Root casue is the cmd_list objects are allocated from slab allocator, and stored its pointer in object allocated by page allocator. The fix will tell kmemleak to track and scan fusion object. Before patch: kmemleak: 1004 new suspected memory leaks (see /sys/kernel/debug/kmemleak) unreferenced object 0xffff88042584e000 (size 8192): backtrace: kmemleak_alloc+0x4a/0xa0 __kmalloc+0xec/0x220 megasas_alloc_cmdlist_fusion+0x3e/0x140 [megaraid_sas] megasas_alloc_cmds_fusion+0x44/0x450 [megaraid_sas] megasas_init_adapter_fusion+0x21d/0x6e0 [megaraid_sas] megasas_init_fw+0x357/0xd30 [megaraid_sas] megasas_probe_one.part.34+0x5be/0x1040 [megaraid_sas] megasas_probe_one+0x46/0xc0 [megaraid_sas] local_pci_probe+0x45/0xa0 work_for_cpu_fn+0x14/0x20 process_one_work+0x149/0x360 worker_thread+0x1d8/0x3c0 kthread+0x109/0x140 ret_from_fork+0x25/0x30 Signed-off-by: Shu Wang --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 11bd2e698b84..621299edd8de 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -48,6 +48,7 @@ #include #include #include +#include #include #include @@ -4512,7 +4513,9 @@ megasas_alloc_fusion_context(struct megasas_instance *instance) dev_err(&instance->pdev->dev, "Failed from %s %d\n", __func__, __LINE__); return -ENOMEM; } - } + } else + kmemleak_alloc(instance->ctrl_context, + sizeof(struct fusion_context), 1, GFP_KERNEL); fusion = instance->ctrl_context; @@ -4548,9 +4551,11 @@ megasas_free_fusion_context(struct megasas_instance *instance) if (is_vmalloc_addr(fusion)) vfree(fusion); - else + else { free_pages((ulong)fusion, instance->ctrl_context_pages); + kmemleak_free(fusion); + } } } -- 2.13.5