Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751542AbdINH55 (ORCPT ); Thu, 14 Sep 2017 03:57:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:60429 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751131AbdINH5y (ORCPT ); Thu, 14 Sep 2017 03:57:54 -0400 Date: Thu, 14 Sep 2017 09:57:52 +0200 From: Johannes Thumshirn To: Lee Duncan Cc: Khazhismel Kumykov , cleech@redhat.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, open-iscsi@googlegroups.com Subject: Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session Message-ID: <20170914075752.6v45mlusxylkqckj@linux-x5ow.site> References: <20170713161122.89375-1-khazhy@google.com> <20170713161122.89375-2-khazhy@google.com> <9be07c2e-71ef-cab4-7b04-94d33a191d03@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9be07c2e-71ef-cab4-7b04-94d33a191d03@suse.com> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 18 On Wed, Sep 13, 2017 at 05:09:03PM -0700, Lee Duncan wrote: > On 07/13/2017 09:11 AM, Khazhismel Kumykov wrote: > > iscsi_session_teardown was the only user of this function. Function > > currently is just short for iscsi_remove_session + iscsi_free_session. > > > > Signed-off-by: Khazhismel Kumykov > > Why is this needed? I dislike changes that don't fix anything. The function has no more users left after patch 1, so why keep it bitrotting? -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850