Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751433AbdINIDJ (ORCPT ); Thu, 14 Sep 2017 04:03:09 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35964 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdINIDG (ORCPT ); Thu, 14 Sep 2017 04:03:06 -0400 X-Google-Smtp-Source: ADKCNb6kTp/efIGNQZHCeppdr73QS1lCTJU9FlkyGCQCvcnnZhgkd90097eohEYkfbe/leIeKnFq9w== Date: Thu, 14 Sep 2017 17:03:02 +0900 From: Sergey Senozhatsky To: Helge Deller Cc: "Luck, Tony" , "linux-kernel@vger.kernel.org" , Sergey Senozhatsky , Petr Mladek , Andrew Morton , "Yu, Fenghua" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Sergey Senozhatsky Subject: Re: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Message-ID: <20170914080302.GF599@jagdpanzerIV.localdomain> References: <20170907083207.GC533@jagdpanzerIV.localdomain> <667b8849-fb60-a312-2483-505252ff737e@gmx.de> <20170907093631.GD533@jagdpanzerIV.localdomain> <20170907095119.GE533@jagdpanzerIV.localdomain> <0604f27e-24ab-625b-9013-c6c0f4f6acc1@gmx.de> <3908561D78D1C84285E8C5FCA982C28F6136C2ED@ORSMSX114.amr.corp.intel.com> <20170908061830.GA496@jagdpanzerIV.localdomain> <20170908172528.qc2vdtxzqh777k6o@intel.com> <67a0aad8-5412-60f8-6481-562d37995eb2@gmx.de> <20170914074044.GE599@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170914074044.GE599@jagdpanzerIV.localdomain> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2357 Lines: 76 On (09/14/17 16:40), Sergey Senozhatsky wrote: [..] > powerpc and parisc handle kernel .opd section as well: > > arch/powerpc/kernel/vmlinux.lds.S: .opd > arch/parisc/kernel/vmlinux.lds.S: .opd for modules, arch-s define mod_arch_specific struct. parisc has .opd (fdesc offset should be the start of .opd, fdesc_offset + sizeof(fdesc) * fdesc_count should be the .opd address range) struct mod_arch_specific { unsigned long got_offset, got_count, got_max; unsigned long fdesc_offset, fdesc_count, fdesc_max; struct { unsigned long stub_offset; unsigned int stub_entries; } *section; int unwind_section; struct unwind_table *unwind; }; ia64 has .opd struct mod_arch_specific { struct elf64_shdr *core_plt; /* core PLT section */ struct elf64_shdr *init_plt; /* init PLT section */ struct elf64_shdr *got; /* global offset table */ struct elf64_shdr *opd; /* official procedure descriptors */ struct elf64_shdr *unwind; /* unwind-table section */ unsigned long gp; /* global-pointer for module */ void *core_unw_table; /* core unwind-table cookie returned by unwinder */ void *init_unw_table; /* init unwind-table cookie returned by unwinder */ unsigned int next_got_entry; /* index of next available got entry */ }; powerpc does not keep track of .opd, need to add struct mod_arch_specific { #ifdef __powerpc64__ unsigned int stubs_section; /* Index of stubs section in module */ unsigned int toc_section; /* What section is the TOC? */ bool toc_fixed; /* Have we fixed up .TOC.? */ #ifdef CONFIG_DYNAMIC_FTRACE unsigned long toc; unsigned long tramp; #endif #else /* powerpc64 */ /* Indices of PLT sections within module. */ unsigned int core_plt_section; unsigned int init_plt_section; #ifdef CONFIG_DYNAMIC_FTRACE unsigned long tramp; #endif #endif /* powerpc64 */ /* List of BUG addresses, source line numbers and filenames */ struct list_head bug_list; struct bug_entry *bug_table; unsigned int num_bugs; }; seems like we are looking at a solution here. thoughts? -ss