Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbdINMcW (ORCPT ); Thu, 14 Sep 2017 08:32:22 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:17055 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbdINMcV (ORCPT ); Thu, 14 Sep 2017 08:32:21 -0400 X-IronPort-AV: E=Sophos;i="5.42,392,1500933600"; d="scan'208";a="291072334" Date: Thu, 14 Sep 2017 14:31:47 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Srishti Sharma cc: gilad@benyossef.com, gregkh@linuxfoundation.org, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: ccree: Use kcalloc instead of kzalloc In-Reply-To: <1505391353-4516-1-git-send-email-srishtishar@gmail.com> Message-ID: References: <1505391353-4516-1-git-send-email-srishtishar@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 43 On Thu, 14 Sep 2017, Srishti Sharma wrote: > Use kcalloc instead of kzalloc to check for overflow before > multiplication. Done using the following semantic patch by > coccinelle. > > http://coccinelle.lip6.fr/rules/kzalloc.cocci > > Signed-off-by: Srishti Sharma > --- > drivers/staging/ccree/ssi_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c > index 0655658..65a0529 100644 > --- a/drivers/staging/ccree/ssi_sysfs.c > +++ b/drivers/staging/ccree/ssi_sysfs.c > @@ -376,7 +376,7 @@ static int sys_init_dir(struct sys_dir *sys_dir, struct ssi_drvdata *drvdata, > return -ENOMEM; > /* allocate memory for directory's attributes list */ > sys_dir->sys_dir_attr_list = > - kzalloc(sizeof(struct attribute *) * (num_of_attrs + 1), > + kcalloc((num_of_attrs + 1), sizeof(struct attribute *), You don't need the parentheses around the first argument. julia > GFP_KERNEL); > > if (!(sys_dir->sys_dir_attr_list)) { > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505391353-4516-1-git-send-email-srishtishar%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >