Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbdINOsE (ORCPT ); Thu, 14 Sep 2017 10:48:04 -0400 Received: from mail-qt0-f179.google.com ([209.85.216.179]:49590 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdINOsC (ORCPT ); Thu, 14 Sep 2017 10:48:02 -0400 X-Google-Smtp-Source: AOwi7QCaAqBG86sugu20Mvm+0Brp7c+Y3gfxpYlbXBBQgebAGM3B5sBJSeROkXpUvL7ONb9K4VEbJg== Subject: Re: [PATCH] scsi: lpfc: remove redundant null check on eqe To: Colin King , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170908080201.9592-1-colin.king@canonical.com> From: James Smart Message-ID: <9d36fb68-7997-cba7-8e27-5b28306e443c@broadcom.com> Date: Thu, 14 Sep 2017 07:47:59 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170908080201.9592-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 425 Lines: 14 On 9/8/2017 1:02 AM, Colin King wrote: > From: Colin Ian King > > The pointer eqe is always non-null inside the while loop, so the > check to see if eqe is NULL is redudant and hence can be removed. > > Detected by CoverityScan CID#1248693 ("Logically Dead Code") > > Signed-off-by: Colin Ian King > Yep. thank you Signed-off-by: James Smart