Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdINO6c (ORCPT ); Thu, 14 Sep 2017 10:58:32 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:56723 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbdINO6b (ORCPT ); Thu, 14 Sep 2017 10:58:31 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support To: Thomas Meyer , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Steven Rostedt , Shuah Khan , Shuah Khan References: <20170908120119.29724-1-thomas@m3y3r.de> From: Shuah Khan Message-ID: <69b9548e-6676-75b4-4ba5-925c5fdc28ac@kernel.org> Date: Thu, 14 Sep 2017 08:58:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170908120119.29724-1-thomas@m3y3r.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 33 On 09/08/2017 06:01 AM, Thomas Meyer wrote: > The multiple_kprobes test case fails to check for KPROBE_EVENT support. > Add the check to prevent a false test result. > > Signed-off-by: Thomas Meyer > --- > tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > index 2a1cb9908746..a4fd4c851a5b 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > @@ -1,6 +1,8 @@ > #!/bin/sh > # description: Register/unregister many kprobe events > > +[ -f kprobe_events ] || exit_unsupported # this is configurable > + > # ftrace fentry skip size depends on the machine architecture. > # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le > case `uname -m` in > Hi Steve/Masami, This patch looks good to me. Adds a check similar to the one one in tools/testing/selftests/ftrace/test.d/kprobe/functions If you don't have objections, I will get this into 4.14-rc2 or rc3 thanks, -- Shuah