Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751555AbdINO7b (ORCPT ); Thu, 14 Sep 2017 10:59:31 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:38029 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbdINO7a (ORCPT ); Thu, 14 Sep 2017 10:59:30 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 2/3] selftests/intel_pstate: No need to compile test progs in the run script To: Thomas Meyer , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20170908120119.29724-1-thomas@m3y3r.de> <20170908120119.29724-2-thomas@m3y3r.de> Cc: Shuah Khan From: Shuah Khan Message-ID: Date: Thu, 14 Sep 2017 08:59:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170908120119.29724-2-thomas@m3y3r.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 38 On 09/08/2017 06:01 AM, Thomas Meyer wrote: > Both test programs are being compiled by make, so no need to compile both > programs in the runner script. > This resolves an error when installing all selftests via make install > and run them in a different environemnt. > > Running tests in intel_pstate > ======================================== > ./run.sh: line 35: gcc: command not found > Problem compiling aperf.c. > > Signed-off-by: Thomas Meyer > --- > tools/testing/selftests/intel_pstate/run.sh | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh > index 7868c106b8b1..96878e44f465 100755 > --- a/tools/testing/selftests/intel_pstate/run.sh > +++ b/tools/testing/selftests/intel_pstate/run.sh > @@ -31,12 +31,6 @@ EVALUATE_ONLY=0 > > max_cpus=$(($(nproc)-1)) > > -# compile programs > -gcc aperf.c -Wall -D_GNU_SOURCE -o aperf -lm > -[ $? -ne 0 ] && echo "Problem compiling aperf.c." && exit 1 > -gcc -o msr msr.c -lm > -[ $? -ne 0 ] && echo "Problem compiling msr.c." && exit 1 > - > function run_test () { > > file_ext=$1 > Thanks for the patch. I will get this into 4.14-rc2 or rc3 thanks, -- Shuah