Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbdINPPW (ORCPT ); Thu, 14 Sep 2017 11:15:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:53088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbdINPPV (ORCPT ); Thu, 14 Sep 2017 11:15:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59A2B21456 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Thu, 14 Sep 2017 08:15:19 -0700 From: Masami Hiramatsu To: shuah@kernel.org Cc: Thomas Meyer , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Shuah Khan Subject: Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support Message-Id: <20170914081519.0e52c5810a7387c20d7b19bb@kernel.org> In-Reply-To: <69b9548e-6676-75b4-4ba5-925c5fdc28ac@kernel.org> References: <20170908120119.29724-1-thomas@m3y3r.de> <69b9548e-6676-75b4-4ba5-925c5fdc28ac@kernel.org> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 51 On Thu, 14 Sep 2017 08:58:20 -0600 Shuah Khan wrote: > On 09/08/2017 06:01 AM, Thomas Meyer wrote: > > The multiple_kprobes test case fails to check for KPROBE_EVENT support. > > Add the check to prevent a false test result. > > > > Signed-off-by: Thomas Meyer > > --- > > tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > index 2a1cb9908746..a4fd4c851a5b 100644 > > --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc > > @@ -1,6 +1,8 @@ > > #!/bin/sh > > # description: Register/unregister many kprobe events > > > > +[ -f kprobe_events ] || exit_unsupported # this is configurable > > + > > # ftrace fentry skip size depends on the machine architecture. > > # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le > > case `uname -m` in > > > > Hi Steve/Masami, > > This patch looks good to me. Adds a check similar to the one one in > tools/testing/selftests/ftrace/test.d/kprobe/functions Yes, this looks good to me too :) Acked-by: Masami Hiramatsu Thanks! > > If you don't have objections, I will get this into 4.14-rc2 or rc3 > > thanks, > -- Shuah > -- > To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Masami Hiramatsu