Subject: Re: [PATCH] gpio: thunderx: remove unused .map() hook from
 irq_domain_ops
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
        linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,
        David Daney <david.daney@cavium.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>, linux-kernel@vger.kernel.org
References: <1505356645-19765-1-git-send-email-yamada.masahiro@socionext.com>
From: David Daney <ddaney@caviumnetworks.com>
Message-ID: <fe9c91d8-33a4-2ecf-8665-3031aa33547f@caviumnetworks.com>
Date: Thu, 14 Sep 2017 09:59:26 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1505356645-19765-1-git-send-email-yamada.masahiro@socionext.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2017 16:59:29.8624 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3491
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1479
Lines: 51

On 09/13/2017 07:37 PM, Masahiro Yamada wrote:
> This driver implements .alloc() hook, so .map() is not used.
> 

Have you tested this?

I will have to test this on a real system next week before I can really 
comment on it.

David.


> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>   drivers/gpio/gpio-thunderx.c | 13 -------------
>   1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c
> index 57efb25..b5adb79 100644
> --- a/drivers/gpio/gpio-thunderx.c
> +++ b/drivers/gpio/gpio-thunderx.c
> @@ -417,18 +417,6 @@ static struct irq_chip thunderx_gpio_irq_chip = {
>   	.flags			= IRQCHIP_SET_TYPE_MASKED
>   };
>   
> -static int thunderx_gpio_irq_map(struct irq_domain *d, unsigned int irq,
> -				 irq_hw_number_t hwirq)
> -{
> -	struct thunderx_gpio *txgpio = d->host_data;
> -
> -	if (hwirq >= txgpio->chip.ngpio)
> -		return -EINVAL;
> -	if (!thunderx_gpio_is_gpio_nowarn(txgpio, hwirq))
> -		return -EPERM;
> -	return 0;
> -}
> -
>   static int thunderx_gpio_irq_translate(struct irq_domain *d,
>   				       struct irq_fwspec *fwspec,
>   				       irq_hw_number_t *hwirq,
> @@ -455,7 +443,6 @@ static int thunderx_gpio_irq_alloc(struct irq_domain *d, unsigned int virq,
>   }
>   
>   static const struct irq_domain_ops thunderx_gpio_irqd_ops = {
> -	.map		= thunderx_gpio_irq_map,
>   	.alloc		= thunderx_gpio_irq_alloc,
>   	.translate	= thunderx_gpio_irq_translate
>   };
>