Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751682AbdINSks (ORCPT ); Thu, 14 Sep 2017 14:40:48 -0400 Received: from webclient5.webclient5.de ([136.243.32.179]:52095 "EHLO webclient5.webclient5.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbdINSkr (ORCPT ); Thu, 14 Sep 2017 14:40:47 -0400 X-Greylist: delayed 583 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Sep 2017 14:40:47 EDT Subject: Re: [alsa-devel] [PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const To: tiwai@suse.com References: <1505397855-10618-1-git-send-email-bhumirks@gmail.com> Cc: Bhumika Goyal , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org From: Clemens Ladisch Message-ID: <61be1ca9-be7c-763d-d7cd-16b2e434a0f9@ladisch.de> Date: Thu, 14 Sep 2017 20:29:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505397855-10618-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 38 Bhumika Goyal wrote: > Make this const as it not modified anywhere. It is only used during a > copy operation. Also, add const to the declaration in header. > > Signed-off-by: Bhumika Goyal Acked-by: Clemens Ladisch > --- > sound/pci/oxygen/xonar_dg.h | 2 +- > sound/pci/oxygen/xonar_dg_mixer.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/oxygen/xonar_dg.h b/sound/pci/oxygen/xonar_dg.h > index d461df3..5a07cda 100644 > --- a/sound/pci/oxygen/xonar_dg.h > +++ b/sound/pci/oxygen/xonar_dg.h > @@ -51,6 +51,6 @@ void dump_cs4245_registers(struct oxygen *chip, > void dg_resume(struct oxygen *chip); > void dg_cleanup(struct oxygen *chip); > > -extern struct oxygen_model model_xonar_dg; > +extern const struct oxygen_model model_xonar_dg; > > #endif > diff --git a/sound/pci/oxygen/xonar_dg_mixer.c b/sound/pci/oxygen/xonar_dg_mixer.c > index b885dac..d22fbe8 100644 > --- a/sound/pci/oxygen/xonar_dg_mixer.c > +++ b/sound/pci/oxygen/xonar_dg_mixer.c > @@ -449,7 +449,7 @@ static int dg_mixer_init(struct oxygen *chip) > return 0; > } > > -struct oxygen_model model_xonar_dg = { > +const struct oxygen_model model_xonar_dg = { > .longname = "C-Media Oxygen HD Audio", > .chip = "CMI8786", > .init = dg_init,