Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbdINSuH (ORCPT ); Thu, 14 Sep 2017 14:50:07 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:54538 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbdINSuF (ORCPT ); Thu, 14 Sep 2017 14:50:05 -0400 Date: Thu, 14 Sep 2017 11:49:49 -0700 From: Mark Brown To: Ryan Lee Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ryan.lee.maxim@gmail.com Subject: Re: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format Message-ID: <20170914184949.enuziddz27polfyf@sirena.org.uk> References: <1505146339-19380-1-git-send-email-ryans.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ll5fravr77dlkf4d" Content-Disposition: inline In-Reply-To: <1505146339-19380-1-git-send-email-ryans.lee@maximintegrated.com> X-Cookie: Don't Worry, Be Happy. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 48 --ll5fravr77dlkf4d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 11, 2017 at 09:12:18AM -0700, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- Please make an effort to write changelogs that clearly describe the change you're making. This is doing way more than just implementing DSP mode, it's also adding a fairly complicated set_tdm_slot() implementation= =20 which isn't mentioned at all. It probably needs splitting into multiple patches as well. > @@ -414,6 +504,9 @@ static int max98927_dac_event(struct snd_soc_dapm_wid= get *w, > struct max98927_priv *max98927 =3D snd_soc_codec_get_drvdata(codec); > =20 > switch (event) { > + case SND_SOC_DAPM_PRE_PMU: > + max98927->tdm_mode =3D 0; > + break; > case SND_SOC_DAPM_POST_PMU: > regmap_update_bits(max98927->regmap, > MAX98927_R003A_AMP_EN, Why is an event associated with the DAC changing something related to the DAI format? These things should be unrelated. --ll5fravr77dlkf4d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlm6z0wACgkQJNaLcl1U h9CNXggAhDxw3LIUGFaO4y03If63k62ypFtQb7Ys61U1kJuYYqlMfhsi50+q5c2r seoJTWoUNLebuqnZw+mTHvRgyumcGSEnaMjrMzEN4xamfpqfRqC2QRmh4uX52wdX fMMo2RLvSW17ZVEbJvXOfOCEVh2otlaSShI1wiLCZsbnDz+OTztBcwtSSfGJDK3h o58GokqtlZQWOUD2qEnvviZRYsV2AJBLyt4Z9euwgPBvCf2Ipc5geSWv6UDl1zHX 3oSxW7pygjVpD7YGgexMcpDOLz1L0QTebvlPxJpSC/QKSv/YxikgjmDTmIl/JQXK jpVu17r5jwLTkC9Rm5u9vFfh/jVnJg== =j+9Q -----END PGP SIGNATURE----- --ll5fravr77dlkf4d--