Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751706AbdINTSG (ORCPT ); Thu, 14 Sep 2017 15:18:06 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:35915 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbdINTSE (ORCPT ); Thu, 14 Sep 2017 15:18:04 -0400 X-Google-Smtp-Source: ADKCNb6qpw7ofSxR4xOOVd0McbN6Y9f8Y4Ejja8bO8i//0jnC9uxEwEPp0AA+0xnf3YF1a/uBcwP52hPgALSJhYYP2Y= MIME-Version: 1.0 In-Reply-To: <20170914191119.y554znlpcnsershp@sasha-lappy> References: <20170914155051.8289-1-alexander.levin@verizon.com> <20170914155051.8289-11-alexander.levin@verizon.com> <20170914191119.y554znlpcnsershp@sasha-lappy> From: Mathieu Malaterre Date: Thu, 14 Sep 2017 21:17:42 +0200 X-Google-Sender-Auth: cLxkbG5WmcmXYKRn2G7RsWAGRfY Message-ID: Subject: Re: [PATCH for 4.9 11/59] MIPS: fix mem=X@Y commandline processing To: "Levin, Alexander (Sasha Levin)" Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Marcin Nowakowski , "linux-mips@linux-mips.org" , Ralf Baechle Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8EJIBr0027162 Content-Length: 2251 Lines: 47 On Thu, Sep 14, 2017 at 9:11 PM, Levin, Alexander (Sasha Levin) wrote: > On Thu, Sep 14, 2017 at 08:59:05PM +0200, Mathieu Malaterre wrote: >>On Thu, Sep 14, 2017 at 5:51 PM, Levin, Alexander (Sasha Levin) >> wrote: >>> From: Marcin Nowakowski >>> >>> [ Upstream commit 73fbc1eba7ffa3bf0ad12486232a8a1edb4e4411 ] >>> >>> When a memory offset is specified through the commandline, add the >>> memory in range PHYS_OFFSET:Y as reserved memory area. >>> Otherwise the bootmem allocator is initialised with low page equal to >>> min_low_pfn = PHYS_OFFSET, and in free_all_bootmem will process pages >>> starting from min_low_pfn instead of PFN(Y). >>> >>> Signed-off-by: Marcin Nowakowski >>> Cc: linux-mips@linux-mips.org >>> Patchwork: https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.linux-2Dmips.org_patch_14613_&d=DwIBaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=bUtaaC9mlBij4OjEG_D-KPul_335azYzfC4Rjgomobo&m=6siOw0e29CYMhuJcboVwEeX-LcC1yJjtnGPVl_1tClQ&s=rP-QGn8HHjuow4b4qd6sfl_EEPoAKkxAffkh1zEq-kc&e= >>> Signed-off-by: Ralf Baechle >>> Signed-off-by: Sasha Levin >>> --- >>> arch/mips/kernel/setup.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c >>> index f66e5ce505b2..38697f25d168 100644 >>> --- a/arch/mips/kernel/setup.c >>> +++ b/arch/mips/kernel/setup.c >>> @@ -589,6 +589,10 @@ static int __init early_parse_mem(char *p) >>> start = memparse(p + 1, &p); >>> >>> add_memory_region(start, size, BOOT_MEM_RAM); >>> + >>> + if (start && start > PHYS_OFFSET) >>> + add_memory_region(PHYS_OFFSET, start - PHYS_OFFSET, >>> + BOOT_MEM_RESERVED); >>> return 0; >>> } >>> early_param("mem", early_parse_mem); >> >>Does not work on MIPS Creator CI20. See: > > Hm, so upstream is actually broken right now? Yes, at least on Creator CI20. You need to clear out all your mem=X@Y from your boot command line, or apply the new patch I mentionned above, or revert 73fbc1eba7ffa3bf0ad12486232a8a1edb4e4411.