Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbdINTUr (ORCPT ); Thu, 14 Sep 2017 15:20:47 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:40144 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbdINTUq (ORCPT ); Thu, 14 Sep 2017 15:20:46 -0400 From: Marc Zyngier To: zijun_hu Cc: , , , , , Subject: Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu() In-Reply-To: <59BA1062.1010406@zoho.com> (zijun hu's message of "Thu, 14 Sep 2017 13:15:14 +0800") Organization: ARM Ltd References: <59BA1062.1010406@zoho.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Thu, 14 Sep 2017 20:20:45 +0100 Message-ID: <86o9qdqe7m.fsf@arm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 15 On Thu, Sep 14 2017 at 1:15:14 pm BST, zijun_hu wrote: > From: zijun_hu > > get_cpu_number() doesn't use existing helper to iterate over possible > CPUs, so error happens in case of discontinuous @cpu_possible_mask > such as 0b11110001. Do you have an example of such a situation? Your patch is definitely an improvement, but I'd like to understand how you get there... Thanks, M. -- Jazz is not dead. It just smells funny.