Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751803AbdINUt6 (ORCPT ); Thu, 14 Sep 2017 16:49:58 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:49594 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbdINUt5 (ORCPT ); Thu, 14 Sep 2017 16:49:57 -0400 Date: Thu, 14 Sep 2017 13:49:54 -0700 From: Christoph Hellwig To: James Morris Cc: Mimi Zohar , linux-security-module@vger.kernel.org, Christoph Hellwig , linux-ima-devel@lists.sourceforge.net, Christoph Hellwig , Linus Torvalds , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version Message-ID: <20170914204954.GA27029@infradead.org> References: <1505270734-4280-1-git-send-email-zohar@linux.vnet.ibm.com> <1505270734-4280-2-git-send-email-zohar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 12 On Fri, Sep 15, 2017 at 06:21:28AM +1000, James Morris wrote: > So, to be clear, this patch solves the XFS deadlock using a different > approach (to the now reverted integrity_read approach), which Christoph > also says is more correct generally. Correct? No. It is in addition to the previous patches - the patches were correct for the IMA interaction with the I/O path. It just turns out that the function was also reused for reading certificates at initialization time, for which that change was incorrect. If this series is applied first the integrity_read code is not used for that path any more.