Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbdINVJ1 (ORCPT ); Thu, 14 Sep 2017 17:09:27 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:56423 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbdINVJZ (ORCPT ); Thu, 14 Sep 2017 17:09:25 -0400 X-Google-Smtp-Source: AOwi7QARqNNoTt9vFCoBPeUTMxh6rdXCizxHut3q8vkdK/F6B87iuOGCPkmoaQ1zSqLOwJ8PH9wYPkDgR7qO/vctYyg= MIME-Version: 1.0 In-Reply-To: References: <20170908070943.GA26549@infradead.org> From: Kees Cook Date: Thu, 14 Sep 2017 14:09:23 -0700 X-Google-Sender-Auth: 0xcjaUXJqJW9_B9NjRaiE2y53TE Message-ID: Subject: Re: [GIT PULL] Security subsystem updates for 4.14 To: James Morris Cc: Paul Moore , Linus Torvalds , LSM List , Christoph Hellwig , Linux Kernel Mailing List , Mimi Zohar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1852 Lines: 57 On Sat, Sep 9, 2017 at 9:32 PM, James Morris wrote: > On Fri, 8 Sep 2017, Paul Moore wrote: > >> > This is also why I tend to prefer getting multiple branches for >> > independent things. > > [...] > >> >> Is it time to start sending pull request for each LSM and thing under >> security/ directly? I'm not sure I have a strong preference either >> way, I just don't want to see the SELinux changes ignored during the >> merge window. > > They won't be ignored, we just need to get this issue resolved now and > figure out how to implement multiple branches in the security tree. > > Looking at other git repos, the x86 folk have multiple branches. Yeah, the x86 approach is what inspired my tree layout. > One option for me would be to publish the trees I pull from as branches > along side mine, with 'next' being a merge of all of directly applied > patchsets and those ready for Linus to pull as one. > > So, branches in > git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security > > might be: > > next-selinux (Paul's next branch) > next-apparmor (JJ's next branch) > next-integrity (Mimi's) > next-tpm (Jarkko's) > [etc.] > > next (merge all of the above to here) > > That way, we have a coherent 'next' branch for people to develop against > and to push to Linus, but he can pull individual branches feeding into it > if something is broken in one of them. > > Does that sound useful? This is what I do with the KSPP tree (since it has a few unrelated things in it), but you run the risk of getting too fine-grain and creating dependencies between trees (e.g. adding a new hook that two LSMs implement means either they depend on each other or both depend on some third "core" tree). How separable are the patches, normally? -Kees -- Kees Cook Pixel Security