Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751618AbdINXy4 convert rfc822-to-8bit (ORCPT ); Thu, 14 Sep 2017 19:54:56 -0400 Received: from mga06.intel.com ([134.134.136.31]:51258 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbdINXyy (ORCPT ); Thu, 14 Sep 2017 19:54:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,395,1500966000"; d="scan'208";a="152041457" From: "Brown, Aaron F" To: Florian Fainelli , "netdev@vger.kernel.org" CC: "edumazet@gmail.com" , open list , "moderated list:INTEL ETHERNET DRIVERS" , "davem@davemloft.net" Subject: RE: [Intel-wired-lan] [PATCH net-next v3] e1000e: Be drop monitor friendly Thread-Topic: [Intel-wired-lan] [PATCH net-next v3] e1000e: Be drop monitor friendly Thread-Index: AQHTHgtpncHCiQhd2k6CGHb3rUIi4qK1LW1A Date: Thu, 14 Sep 2017 23:54:52 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C6A057B@ORSMSX101.amr.corp.intel.com> References: <20170826011424.27251-1-f.fainelli@gmail.com> In-Reply-To: <20170826011424.27251-1-f.fainelli@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 32 > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf > Of Florian Fainelli > Sent: Friday, August 25, 2017 6:14 PM > To: netdev@vger.kernel.org > Cc: edumazet@gmail.com; Florian Fainelli ; open list > ; moderated list:INTEL ETHERNET DRIVERS > ; davem@davemloft.net > Subject: [Intel-wired-lan] [PATCH net-next v3] e1000e: Be drop monitor > friendly > > e1000e_put_txbuf() can be called from normal reclamation path as well as > when a DMA mapping failure, so we need to differentiate these two cases > when freeing SKBs to be drop monitor friendly. e1000e_tx_hwtstamp_work() > and e1000_remove() are processing TX timestamped SKBs and those should > not be accounted as drops either. > > Signed-off-by: Florian Fainelli > --- > Changes in v3: > > - differentiate normal reclamation from TX DMA fragment mapping errors > - removed a few invalid dev_kfree_skb() replacements (those are already > drop monitor friendly) > > Changes in v2: > > - make it compile > > drivers/net/ethernet/intel/e1000e/netdev.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) Tested-by: Aaron Brown