Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751648AbdIOASv convert rfc822-to-8bit (ORCPT ); Thu, 14 Sep 2017 20:18:51 -0400 Received: from mga09.intel.com ([134.134.136.24]:31896 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdIOASt (ORCPT ); Thu, 14 Sep 2017 20:18:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,395,1500966000"; d="scan'208";a="152048483" From: "Brown, Aaron F" To: Benjamin Poirier , "Kirsher, Jeffrey T" CC: "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" , "Lennart Sorensen" Subject: RE: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection Thread-Topic: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection Thread-Index: AQHTAlBgr6t4yTAAvUyVEVuZ4CBN/KK1a6CA Date: Fri, 15 Sep 2017 00:18:47 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C6A059F@ORSMSX101.amr.corp.intel.com> References: <20170721160937.GA22632@csclub.uwaterloo.ca> <20170721183627.13373-1-bpoirier@suse.com> In-Reply-To: <20170721183627.13373-1-bpoirier@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 756 Lines: 18 > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf > Of Benjamin Poirier > Sent: Friday, July 21, 2017 11:36 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux- > kernel@vger.kernel.org; Lennart Sorensen > Subject: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection > > In case of error from e1e_rphy(), the loop will exit early and "success" > will be set to true erroneously. > > Signed-off-by: Benjamin Poirier > --- > drivers/net/ethernet/intel/e1000e/phy.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Tested-by: Aaron Brown