Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751803AbdIOBtb (ORCPT ); Thu, 14 Sep 2017 21:49:31 -0400 Received: from conssluserg-01.nifty.com ([210.131.2.80]:54838 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbdIOBta (ORCPT ); Thu, 14 Sep 2017 21:49:30 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com v8F1nPmb017763 X-Nifty-SrcIP: [209.85.161.181] X-Google-Smtp-Source: ADKCNb4j0k1IasqrtXVHyO2y18ftkZeNGP9YYSWQsibu/vr8p0Xl5dAc1sqvz5bZUDzKySOlEkLCIYnwEJbiTISxmrA= MIME-Version: 1.0 In-Reply-To: References: <1505356645-19765-1-git-send-email-yamada.masahiro@socionext.com> From: Masahiro Yamada Date: Fri, 15 Sep 2017 10:48:44 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops To: David Daney Cc: linux-gpio@vger.kernel.org, Linus Walleij , David Daney , Thomas Gleixner , Jason Cooper , Marc Zyngier , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2153 Lines: 74 Hi David, 2017-09-15 1:59 GMT+09:00 David Daney : > On 09/13/2017 07:37 PM, Masahiro Yamada wrote: >> >> This driver implements .alloc() hook, so .map() is not used. >> > > Have you tested this? No. I do not have access to this hardware. It is just, in my understanding, .alloc() and .map() are exclusive. > I will have to test this on a real system next week before I can really > comment on it. > > David. > > > > >> Signed-off-by: Masahiro Yamada >> --- >> >> drivers/gpio/gpio-thunderx.c | 13 ------------- >> 1 file changed, 13 deletions(-) >> >> diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c >> index 57efb25..b5adb79 100644 >> --- a/drivers/gpio/gpio-thunderx.c >> +++ b/drivers/gpio/gpio-thunderx.c >> @@ -417,18 +417,6 @@ static struct irq_chip thunderx_gpio_irq_chip = { >> .flags = IRQCHIP_SET_TYPE_MASKED >> }; >> -static int thunderx_gpio_irq_map(struct irq_domain *d, unsigned int >> irq, >> - irq_hw_number_t hwirq) >> -{ >> - struct thunderx_gpio *txgpio = d->host_data; >> - >> - if (hwirq >= txgpio->chip.ngpio) >> - return -EINVAL; >> - if (!thunderx_gpio_is_gpio_nowarn(txgpio, hwirq)) >> - return -EPERM; >> - return 0; >> -} >> - >> static int thunderx_gpio_irq_translate(struct irq_domain *d, >> struct irq_fwspec *fwspec, >> irq_hw_number_t *hwirq, >> @@ -455,7 +443,6 @@ static int thunderx_gpio_irq_alloc(struct irq_domain >> *d, unsigned int virq, >> } >> static const struct irq_domain_ops thunderx_gpio_irqd_ops = { >> - .map = thunderx_gpio_irq_map, >> .alloc = thunderx_gpio_irq_alloc, >> .translate = thunderx_gpio_irq_translate >> }; >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada