Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbdIODVF (ORCPT ); Thu, 14 Sep 2017 23:21:05 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:46308 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbdIODVD (ORCPT ); Thu, 14 Sep 2017 23:21:03 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: rocky.hao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: rocky.hao@rock-chips.com X-UNIQUE-TAG: <1d7190261278bcf6708e465e1d27ea8a> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RV1108 SoC compatible To: Caesar Wang Cc: rui.zhang@intel.com, edubezval@gmail.com, heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, huangtao@rock-chips.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, shawn.lin@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, cl@rock-chips.com, william.wu@rock-chips.com, jay.xu@rock-chips.com, xxx@rock-chips.com, linux-arm-kernel@lists.infradead.org References: <1503570475-7850-1-git-send-email-rocky.hao@rock-chips.com> <1503570475-7850-2-git-send-email-rocky.hao@rock-chips.com> <12073627-41af-3480-6379-839e07f5e8f3@rock-chips.com> From: "rocky.hao" Message-ID: Date: Fri, 15 Sep 2017 11:20:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <12073627-41af-3480-6379-839e07f5e8f3@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1168 Lines: 36 Hi Caesar, Thanks for the reply. 在 2017/9/15 9:49, Caesar Wang 写道: > Hi Rocky, > > 在 2017年08月24日 18:27, Rocky Hao 写道: >> Add a new compatible for thermal founding on RV1108 SoCs. >> >> Signed-off-by: Rocky Hao >> --- >> Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> index e3a6234fb1ac..43d744e5305e 100644 >> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> @@ -2,6 +2,7 @@ >> Required properties: >> - compatible : should be "rockchip,-tsadc" >> + "rockchip,rv1108-tsadc": found on RV1108 SoCs > > According to the order, we should put the string after the > "rockchip,rk3399-tsadc"..., not here. It is okay for me. >> "rockchip,rk3228-tsadc": found on RK3228 SoCs >> "rockchip,rk3288-tsadc": found on RK3288 SoCs >> "rockchip,rk3328-tsadc": found on RK3328 SoCs > > > >