Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbdIOIs4 convert rfc822-to-8bit (ORCPT ); Fri, 15 Sep 2017 04:48:56 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:51329 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750879AbdIOIsz (ORCPT ); Fri, 15 Sep 2017 04:48:55 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Colin King , "Sumit Semwal" , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20170914230516.6056-1-colin.king@canonical.com> Cc: linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170914230516.6056-1-colin.king@canonical.com> Message-ID: <150546532831.19729.6169136066415731528@mail.alporthouse.com> User-Agent: alot/0.3.6 Subject: Re: [PATCH] dma-buf: remove redundant initialization of sg_table Date: Fri, 15 Sep 2017 09:48:48 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 14 Quoting Colin King (2017-09-15 00:05:16) > From: Colin Ian King > > sg_table is being initialized and is never read before it is updated > again later on, hence making the initialization redundant. Remove > the initialization. > > Detected by clang scan-build: > "warning: Value stored to 'sg_table' during its initialization is > never read" > > Signed-off-by: Colin Ian King Reviewed-by: Chris Wilson -Chris