Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370AbdIOKWX (ORCPT ); Fri, 15 Sep 2017 06:22:23 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:50865 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdIOKWW (ORCPT ); Fri, 15 Sep 2017 06:22:22 -0400 Date: Fri, 15 Sep 2017 12:22:19 +0200 From: Pavel Machek To: Ingo Molnar Cc: Linus Torvalds , Andy Lutomirski , X86 ML , Borislav Petkov , "linux-kernel@vger.kernel.org" Subject: [4.14-rc0 regression] Re: x60: warnings on boot and resume, arch/x86/mm/tlb.c:257 initialize_ ... was Re: [PATCH 0/2] Fix resume failure due to PCID Message-ID: <20170915102219.GA4312@amd> References: <20170915065936.GA6580@amd> <20170915083901.aql6zkcabewy52kb@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: <20170915083901.aql6zkcabewy52kb@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 16757 Lines: 357 --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Ok, seems this is still not completely right, I'm now getting WARN_ON > > during boot and on every resume... but machine works. > >=20 > > 4.14-rc0, 32-bit. >=20 > Which SHA1, just to make sure? (Please enable CONFIG_LOCALVERSION_AUTO=3D= y.) >=20 > > [ 0.004000] Initializing CPU#1 > > [ 0.004000] ------------[ cut here ]------------ > > [ 0.004000] WARNING: CPU: 1 PID: 0 at arch/x86/mm/tlb.c:257 initiali= ze_tlbstate_and_flush+0x27/0xcf > > [ 0.004000] Modules linked in: > > [ 0.004000] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.13.0+ #429 > > [ 0.004000] Hardware name: LENOVO 17097HU/17097HU, BIOS 7BETD8WW (2.= 19 ) 03/31/2011 > > [ 0.004000] task: f5ca2080 task.stack: f5cc4000 > > [ 0.004000] EIP: initialize_tlbstate_and_flush+0x27/0xcf > > [ 0.004000] EFLAGS: 00210087 CPU: 1 > > [ 0.004000] EAX: 00000000 EBX: c506d540 ECX: 051b2000 EDX: 00000000 > > [ 0.004000] ESI: 0503f000 EDI: c51b2000 EBP: f5cc5f54 ESP: f5cc5f48 > > [ 0.004000] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 > > [ 0.004000] CR0: 80050033 CR2: 00000000 CR3: 0503f000 CR4: 000006b0 > > [ 0.004000] Call Trace: > > [ 0.004000] cpu_init+0xdc/0x2f0 > > [ 0.004000] start_secondary+0x34/0x1c6 > > [ 0.004000] startup_32_smp+0x164/0x166 > > [ 0.004000] ? startup_32_smp+0x164/0x166 >=20 > Could you please try the debug patch below, so that we get a bit > more info? Let me pull latest... 711aab1dbb324d321e3d84368a435a78908c7bce (Strange. Not authored by Linus and old?) Applying patch is easy enough. > @@ -254,7 +254,8 @@ void initialize_tlbstate_and_flush(void) > unsigned long cr3 =3D __read_cr3(); > =20 > /* Assert that CR3 already references the right mm. */ > - WARN_ON((cr3 & CR3_ADDR_MASK) !=3D __pa(mm->pgd)); > + if (WARN_ON((cr3 & CR3_ADDR_MASK) !=3D __pa(mm->pgd))) > + printk("# CR3: %016lx, __pa(mm->pgd): %016lx\n", cr3, __pa(mm->pgd)); > =20 > /* > * Assert that CR4.PCIDE is set if needed. (CR4.PCIDE initialization But result is still similar, this time with more debug information. Best regards, Pavel [ 0.000000] Linux version 4.13.0+ (pavel@duo) (gcc version 4.9.2 (Debian= 4.9.2-10)) #431 SMP Fri Sep 15 12:05:10 CEST 2017 [ 0.000000] Disabled fast string operations [ 0.000000] x86/fpu: x87 FPU will use FXSAVE [ 0.000000] e820: BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009efff] usable [ 0.000000] BIOS-e820: [mem 0x000000000009f000-0x000000000009ffff] reser= ved [ 0.000000] BIOS-e820: [mem 0x00000000000dc000-0x00000000000fffff] reser= ved [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x00000000bf6cffff] usable [ 0.000000] BIOS-e820: [mem 0x00000000bf6d0000-0x00000000bf6defff] ACPI = data [ 0.000000] BIOS-e820: [mem 0x00000000bf6df000-0x00000000bf6fffff] ACPI = NVS [ 0.000000] BIOS-e820: [mem 0x00000000bf700000-0x00000000bfffffff] reser= ved [ 0.000000] BIOS-e820: [mem 0x00000000f0000000-0x00000000f3ffffff] reser= ved [ 0.000000] BIOS-e820: [mem 0x00000000fec00000-0x00000000fec0ffff] reser= ved [ 0.000000] BIOS-e820: [mem 0x00000000fed00000-0x00000000fed003ff] reser= ved [ 0.000000] BIOS-e820: [mem 0x00000000fed14000-0x00000000fed19fff] reser= ved [ 0.000000] BIOS-e820: [mem 0x00000000fed1c000-0x00000000fed8ffff] reser= ved [ 0.000000] BIOS-e820: [mem 0x00000000fee00000-0x00000000fee00fff] reser= ved [ 0.000000] BIOS-e820: [mem 0x00000000ff800000-0x00000000ffffffff] reser= ved [ 0.000000] NX (Execute Disable) protection: active [ 0.000000] random: fast init done [ 0.000000] SMBIOS 2.4 present. [ 0.000000] DMI: LENOVO 17097HU/17097HU, BIOS 7BETD8WW (2.19 ) 03/31/2011 [ 0.000000] tsc: Fast TSC calibration using PIT [ 0.000000] e820: update [mem 0x00000000-0x00000fff] usable =3D=3D> rese= rved [ 0.000000] e820: remove [mem 0x000a0000-0x000fffff] usable [ 0.000000] e820: last_pfn =3D 0xbf6d0 max_arch_pfn =3D 0x1000000 [ 0.000000] MTRR default type: uncachable [ 0.000000] MTRR fixed ranges enabled: [ 0.000000] 00000-9FFFF write-back [ 0.000000] A0000-BFFFF uncachable [ 0.000000] C0000-CFFFF write-protect [ 0.000000] D0000-DBFFF uncachable [ 0.000000] DC000-DFFFF write-back [ 0.000000] E0000-FFFFF write-protect [ 0.000000] MTRR variable ranges enabled: [ 0.000000] 0 base 000000000 mask F80000000 write-back [ 0.000000] 1 base 080000000 mask FC0000000 write-back [ 0.000000] 2 base 0BF700000 mask FFFF00000 uncachable [ 0.000000] 3 base 0BF800000 mask FFF800000 uncachable [ 0.000000] 4 disabled [ 0.000000] 5 disabled [ 0.000000] 6 disabled [ 0.000000] 7 disabled [ 0.000000] x86/PAT: PAT not supported by CPU. [ 0.000000] x86/PAT: Configuration [0-7]: WB WT UC- UC WB WT UC- UC= =20 [ 0.000000] initial memory mapped: [mem 0x00000000-0x05bfffff] [ 0.000000] Base memory trampoline at [c009b000] 9b000 size 16384 [ 0.000000] BRK [0x0567f000, 0x0567ffff] PGTABLE [ 0.000000] BRK [0x05680000, 0x05680fff] PGTABLE [ 0.000000] ACPI: Early table checksum verification disabled [ 0.000000] ACPI: RSDP 0x00000000000F67C0 000024 (v02 LENOVO) [ 0.000000] ACPI: XSDT 0x00000000BF6D191C 000084 (v01 LENOVO TP-7B 00= 002190 LTP 00000000) [ 0.000000] ACPI: FACP 0x00000000BF6D1A00 0000F4 (v03 LENOVO TP-7B 00= 002190 LNVO 00000001) [ 0.000000] ACPI BIOS Warning (bug): 32/64X length mismatch in FADT/Gpe0= Block: 64/32 (20170728/tbfadt-603) [ 0.000000] ACPI BIOS Warning (bug): Optional FADT field Gpe1Block has v= alid Address but zero Length: 0x000000000000102C/0x0 (20170728/tbfadt-658) [ 0.000000] ACPI: DSDT 0x00000000BF6D1D90 00CFB9 (v01 LENOVO TP-7B 00= 002190 MSFT 0100000E) [ 0.000000] ACPI: FACS 0x00000000BF6F4000 000040 [ 0.000000] ACPI: FACS 0x00000000BF6F4000 000040 [ 0.000000] ACPI: SSDT 0x00000000BF6D1BB4 0001DC (v01 LENOVO TP-7B 00= 002190 MSFT 0100000E) [ 0.000000] ACPI: ECDT 0x00000000BF6DED49 000052 (v01 LENOVO TP-7B 00= 002190 LNVO 00000001) [ 0.000000] ACPI: TCPA 0x00000000BF6DED9B 000032 (v02 LENOVO TP-7B 00= 002190 LNVO 00000001) [ 0.000000] ACPI: APIC 0x00000000BF6DEDCD 000068 (v01 LENOVO TP-7B 00= 002190 LNVO 00000001) [ 0.000000] ACPI: MCFG 0x00000000BF6DEE35 00003C (v01 LENOVO TP-7B 00= 002190 LNVO 00000001) [ 0.000000] ACPI: HPET 0x00000000BF6DEE71 000038 (v01 LENOVO TP-7B 00= 002190 LNVO 00000001) [ 0.000000] ACPI: BOOT 0x00000000BF6DEFD8 000028 (v01 LENOVO TP-7B 00= 002190 LTP 00000001) [ 0.000000] ACPI: SSDT 0x00000000BF6F2645 00025F (v01 LENOVO TP-7B 00= 002190 INTL 20050513) [ 0.000000] ACPI: SSDT 0x00000000BF6F28A4 0000A6 (v01 LENOVO TP-7B 00= 002190 INTL 20050513) [ 0.000000] ACPI: SSDT 0x00000000BF6F294A 0004F7 (v01 LENOVO TP-7B 00= 002190 INTL 20050513) [ 0.000000] ACPI: SSDT 0x00000000BF6F2E41 0001D8 (v01 LENOVO TP-7B 00= 002190 INTL 20050513) [ 0.000000] ACPI: Local APIC address 0xfee00000 [ 0.000000] 2170MB HIGHMEM available. [ 0.000000] 891MB LOWMEM available. [ 0.000000] mapped low ram: 0 - 37bfe000 [ 0.000000] low ram: 0 - 37bfe000 [ 0.000000] Zone ranges: [ 0.000000] DMA [mem 0x0000000000001000-0x0000000000ffffff] [ 0.000000] Normal [mem 0x0000000001000000-0x0000000037bfdfff] [ 0.000000] HighMem [mem 0x0000000037bfe000-0x00000000bf6cffff] [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x0000000000001000-0x000000000009efff] [ 0.000000] node 0: [mem 0x0000000000100000-0x00000000bf6cffff] [ 0.000000] Initmem setup node 0 [mem 0x0000000000001000-0x00000000bf6cf= fff] [ 0.000000] On node 0 totalpages: 783982 [ 0.000000] free_area_init_node: node 0, pgdat c4f6fe00, node_mem_map f6= 40e020 [ 0.000000] DMA zone: 32 pages used for memmap [ 0.000000] DMA zone: 0 pages reserved [ 0.000000] DMA zone: 3998 pages, LIFO batch:0 [ 0.000000] Normal zone: 1752 pages used for memmap [ 0.000000] Normal zone: 224254 pages, LIFO batch:31 [ 0.000000] HighMem zone: 555730 pages, LIFO batch:31 [ 0.000000] Using APIC driver default [ 0.000000] Reserving Intel graphics memory at 0x00000000bf800000-0x0000= 0000bfffffff [ 0.000000] ACPI: PM-Timer IO Port: 0x1008 [ 0.000000] ACPI: Local APIC address 0xfee00000 [ 0.000000] ACPI: LAPIC_NMI (acpi_id[0x00] high edge lint[0x1]) [ 0.000000] ACPI: LAPIC_NMI (acpi_id[0x01] high edge lint[0x1]) [ 0.000000] IOAPIC[0]: apic_id 1, version 32, address 0xfec00000, GSI 0-= 23 [ 0.000000] ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl) [ 0.000000] ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level) [ 0.000000] ACPI: IRQ0 used by override. [ 0.000000] ACPI: IRQ9 used by override. [ 0.000000] Using ACPI (MADT) for SMP configuration information [ 0.000000] ACPI: HPET id: 0x8086a201 base: 0xfed00000 [ 0.000000] smpboot: Allowing 2 CPUs, 0 hotplug CPUs [ 0.000000] PM: Registered nosave memory: [mem 0x00000000-0x00000fff] [ 0.000000] PM: Registered nosave memory: [mem 0x0009f000-0x0009ffff] [ 0.000000] PM: Registered nosave memory: [mem 0x000a0000-0x000dbfff] [ 0.000000] PM: Registered nosave memory: [mem 0x000dc000-0x000fffff] [ 0.000000] e820: [mem 0xc0000000-0xefffffff] available for PCI devices [ 0.000000] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0= xffffffff, max_idle_ns: 7645519600211568 ns [ 0.000000] setup_percpu: NR_CPUS:8 nr_cpumask_bits:8 nr_cpu_ids:2 nr_no= de_ids:1 [ 0.000000] percpu: Embedded 22 pages/cpu @f63df000 s57704 r0 d32408 u90= 112 [ 0.000000] pcpu-alloc: s57704 r0 d32408 u90112 alloc=3D22*4096 [ 0.000000] pcpu-alloc: [0] 0 [0] 1=20 [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 782198 [ 0.000000] Kernel command line: BOOT_IMAGE=3D(hd0,2)/fast/l/linux/arch/= x86/boot/bzImage root=3D/dev/sda4 resume=3D/dev/sda1 [ 0.000000] PID hash table entries: 4096 (order: 2, 16384 bytes) [ 0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 by= tes) [ 0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 byte= s) [ 0.000000] Initializing CPU#0 [ 0.000000] Initializing HighMem for node 0 (00037bfe:000bf6d0) [ 0.000000] Initializing Movable for node 0 (00000000:00000000) [ 0.000000] Memory: 3087308K/3135928K available (10401K kernel code, 689= K rwdata, 4832K rodata, 564K init, 6176K bss, 48620K reserved, 0K cma-reser= ved, 2222920K highmem) [ 0.000000] virtual kernel memory layout: fixmap : 0xffe67000 - 0xfffff000 (1632 kB) pkmap : 0xffc00000 - 0xffe00000 (2048 kB) vmalloc : 0xf83fe000 - 0xffbfe000 ( 120 MB) lowmem : 0xc0000000 - 0xf7bfe000 ( 891 MB) .init : 0xc4fb1000 - 0xc503e000 ( 564 kB) .data : 0xc4a287bc - 0xc4f906c0 (5535 kB) .text : 0xc4000000 - 0xc4a287bc (10401 kB) [ 0.000000] Checking if this processor honours the WP bit even in superv= isor mode...Ok. [ 0.000000] Hierarchical RCU implementation. [ 0.000000] RCU restricting CPUs from NR_CPUS=3D8 to nr_cpu_ids=3D2. [ 0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=3D16, nr_cpu_ids= =3D2 [ 0.000000] NR_IRQS: 2304, nr_irqs: 440, preallocated irqs: 16 [ 0.000000] CPU 0 irqstacks, hard=3Df5c0e000 soft=3Df5c10000 [ 0.000000] Console: colour VGA+ 80x25 [ 0.000000] console [tty0] enabled [ 0.000000] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc.,= Ingo Molnar [ 0.000000] ... MAX_LOCKDEP_SUBCLASSES: 8 [ 0.000000] ... MAX_LOCK_DEPTH: 48 [ 0.000000] ... MAX_LOCKDEP_KEYS: 8191 [ 0.000000] ... CLASSHASH_SIZE: 4096 [ 0.000000] ... MAX_LOCKDEP_ENTRIES: 32768 [ 0.000000] ... MAX_LOCKDEP_CHAINS: 65536 [ 0.000000] ... CHAINHASH_SIZE: 32768 [ 0.000000] memory used by lock dependency info: 4383 kB [ 0.000000] per task-struct memory footprint: 1344 bytes [ 0.000000] clocksource: hpet: mask: 0xffffffff max_cycles: 0xffffffff, = max_idle_ns: 133484882848 ns [ 0.000000] hpet clockevent registered [ 0.000000] tsc: Fast TSC calibration using PIT [ 0.004000] tsc: Detected 1828.818 MHz processor [ 0.004000] Calibrating delay loop (skipped), value calculated using tim= er frequency.. 3657.63 BogoMIPS (lpj=3D7315272) [ 0.004000] pid_max: default: 32768 minimum: 301 [ 0.004000] ACPI: Core revision 20170728 [ 0.067814] ACPI: 6 ACPI AML tables successfully acquired and loaded [ 0.068163] Mount-cache hash table entries: 2048 (order: 1, 8192 bytes) [ 0.068254] Mountpoint-cache hash table entries: 2048 (order: 1, 8192 by= tes) [ 0.068999] Disabled fast string operations [ 0.069074] CPU: Physical Processor ID: 0 [ 0.069146] CPU: Processor Core ID: 0 [ 0.069224] process: using mwait in idle threads [ 0.069306] Last level iTLB entries: 4KB 128, 2MB 0, 4MB 2 [ 0.069385] Last level dTLB entries: 4KB 128, 2MB 0, 4MB 8, 1GB 0 [ 0.069632] Freeing SMP alternatives memory: 40K [ 0.072271] smpboot: Max logical packages: 1 [ 0.072350] Enabling APIC mode: Flat. Using 1 I/O APICs [ 0.073008] ..TIMER: vector=3D0x30 apic1=3D0 pin1=3D2 apic2=3D-1 pin2=3D= -1 [ 0.116000] smpboot: CPU0: Genuine Intel(R) CPU T2400 @ 1.83G= Hz (family: 0x6, model: 0xe, stepping: 0x8) [ 0.116000] Performance Events: Core events, core PMU driver. [ 0.116000] ... version: 1 [ 0.116000] ... bit width: 40 [ 0.116000] ... generic registers: 2 [ 0.116000] ... value mask: 000000ffffffffff [ 0.116000] ... max period: 000000007fffffff [ 0.116000] ... fixed-purpose events: 0 [ 0.116000] ... event mask: 0000000000000003 [ 0.116000] Hierarchical SRCU implementation. [ 0.116000] smp: Bringing up secondary CPUs ... [ 0.116091] NMI watchdog: enabled on all CPUs, permanently consumes one = hw-PMU counter. [ 0.116809] CPU 1 irqstacks, hard=3Df5cd6000 soft=3Df5cd8000 [ 0.116813] x86: Booting SMP configuration: [ 0.116893] .... node #0, CPUs: #1 [ 0.004000] Initializing CPU#1 [ 0.004000] ------------[ cut here ]------------ [ 0.004000] WARNING: CPU: 1 PID: 0 at arch/x86/mm/tlb.c:257 initialize_t= lbstate_and_flush+0x2e/0xed [ 0.004000] Modules linked in: [ 0.004000] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.13.0+ #431 [ 0.004000] Hardware name: LENOVO 17097HU/17097HU, BIOS 7BETD8WW (2.19 )= 03/31/2011 [ 0.004000] task: f5ca2080 task.stack: f5cc4000 [ 0.004000] EIP: initialize_tlbstate_and_flush+0x2e/0xed [ 0.004000] EFLAGS: 00210087 CPU: 1 [ 0.004000] EAX: 0504b000 EBX: c4f15540 ECX: c4f15710 EDX: 00000000 [ 0.004000] ESI: 04ee7000 EDI: f5ca2080 EBP: f5cc5f54 ESP: f5cc5f44 [ 0.004000] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 [ 0.004000] CR0: 80050033 CR2: 00000000 CR3: 04ee7000 CR4: 000006b0 [ 0.004000] Call Trace: [ 0.004000] cpu_init+0xdc/0x2f0 [ 0.004000] start_secondary+0x34/0x1c6 [ 0.004000] startup_32_smp+0x164/0x166 [ 0.004000] ? startup_32_smp+0x164/0x166 [ 0.004000] Code: 56 53 83 ec 08 64 8b 1d c0 c0 03 c5 b9 10 57 f1 c4 e8 = de 65 9e 00 89 45 f0 89 55 f4 0f 20 de 8b 43 20 05 00 00 00 40 39 c6 74 11 = <0f> ff 50 56 68 74 9c d8 c4 e8 d1 cd 04 00 83 c4 0c a1 20 90 f8 [ 0.004000] ---[ end trace 7439e29925a49b51 ]--- [ 0.004000] # CR3: 0000000004ee7000, __pa(mm->pgd): 000000000504b000 [ 0.004000] Disabled fast string operations [ 0.198012] TSC synchronization [CPU#0 -> CPU#1]: [ 0.200000] Measured 579854 cycles TSC warp between CPUs, turning off TS= C clock. [ 0.200000] tsc: Marking TSC unstable due to check_tsc_sync_source failed [ 0.200082] smp: Brought up 1 node, 2 CPUs [ 0.200086] smpboot: Total of 2 processors activated (7315.14 BogoMIPS) [ 0.201822] devtmpfs: initialized [ 0.204623] PM: Registering ACPI NVS region [mem 0xbf6df000-0xbf6fffff] = (135168 bytes) [ 0.205027] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlm7qdsACgkQMOfwapXb+vIy5QCgrFI7p/aHO4zu9UG+pBo9Qfl/ vgwAoJHVl8a574cuizltimgjjg8JQMJF =kA6A -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v--