DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 051F7461C1
Date: Fri, 15 Sep 2017 10:28:52 -0400
From: Joe Lawrence <joe.lawrence@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: __klp_shadow_get_or_alloc() is local to
 shadow.c
Message-ID: <20170915142852.tzqi7w3ednwvhh54@redhat.com>
References: <nycvar.YFH.7.76.1709141410350.4703@jbgna.fhfr.qr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <nycvar.YFH.7.76.1709141410350.4703@jbgna.fhfr.qr>
User-Agent: Mutt/1.6.2-neo (2016-08-08)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1140
Lines: 38

On Thu, Sep 14, 2017 at 02:15:36PM -0700, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> 
> ... therefore make it static.
> 
> Fixes: 439e7271dc2 ("livepatch: introduce shadow variable API")
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
> 
> Sorry for not having spotted this before pushing out.
> 
>  kernel/livepatch/shadow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/livepatch/shadow.c b/kernel/livepatch/shadow.c
> index 67e4360..fdac275 100644
> --- a/kernel/livepatch/shadow.c
> +++ b/kernel/livepatch/shadow.c
> @@ -113,7 +113,7 @@ void *klp_shadow_get(void *obj, unsigned long id)
>  }
>  EXPORT_SYMBOL_GPL(klp_shadow_get);
>  
> -void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> +static void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
>  		       size_t size, gfp_t gfp_flags, bool warn_on_exist)
>  {
>  	struct klp_shadow *new_shadow;
> -- 
> 1.8.5.6

Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

Thanks for cleaning this up, Jiri.

Also thanks to Miroslav, Petr, Nicolai and Josh for the patchset
reviews!

-- Joe