Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751463AbdIOQRq (ORCPT ); Fri, 15 Sep 2017 12:17:46 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:29241 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbdIOQRo (ORCPT ); Fri, 15 Sep 2017 12:17:44 -0400 X-IronPort-AV: E=Sophos;i="5.42,397,1500912000"; d="scan'208";a="153773121" From: Bart Van Assche To: "jejb@linux.vnet.ibm.com" , "martin.petersen@oracle.com" , "shuwang@redhat.com" , "kashyap.desai@broadcom.com" , "shivasharan.srikanteshwara@broadcom.com" , "sumit.saxena@broadcom.com" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chuhu@redhat.com" , "catalin.marinas@arm.com" , "yizhan@redhat.com" , "megaraidlinux.pdl@broadcom.com" Subject: Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion Thread-Topic: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion Thread-Index: AQHTLeK+46frzVFW10uruMgLezB1JqK2IFKA Date: Fri, 15 Sep 2017 16:16:57 +0000 Message-ID: <1505492215.3420.1.camel@wdc.com> References: <20170915052152.5032-1-shuwang@redhat.com> In-Reply-To: <20170915052152.5032-1-shuwang@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [12.145.98.253] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1402;20:SxItZasWitj4cBPtlYkRjNjhjt+h/n1e7wGvMByfr/Jwa9Yn+4abpT2aU606sy8/TNLHYCZDo318SJD0wWh867/O55TuszfK/GmNjegEIN7P8EMskXag995nhWSZ4qQTM9lZ2EQNn0OA0hEtTms/Crlx7ytU8lp2JCF0Td0ZNps= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 2f8ef65d-aff3-4126-5037-08d4fc552ffa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY1PR0401MB1402; x-ms-traffictypediagnostic: CY1PR0401MB1402: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1402;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1402; x-forefront-prvs: 0431F981D8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(39860400002)(376002)(189002)(24454002)(199003)(377424004)(36756003)(77096006)(6486002)(6506006)(66066001)(2900100001)(103116003)(97736004)(8936002)(5660300001)(2950100002)(8676002)(68736007)(7736002)(81156014)(105586002)(305945005)(106356001)(25786009)(6116002)(316002)(33646002)(229853002)(2906002)(3846002)(102836003)(7416002)(6436002)(81166006)(3280700002)(53936002)(189998001)(2201001)(4326008)(3660700001)(86362001)(101416001)(6246003)(14454004)(54906002)(6512007)(99286003)(50986999)(76176999)(54356999)(2501003)(72206003)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1402;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2017 16:16:57.2810 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1402 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8FGHp09010299 Content-Length: 506 Lines: 17 On Fri, 2017-09-15 at 13:21 +0800, shuwang@redhat.com wrote: > @@ -4548,9 +4556,11 @@ megasas_free_fusion_context(struct megasas_instance *instance) > > if (is_vmalloc_addr(fusion)) > vfree(fusion); > - else > + else { > + kmemleak_free(fusion); > free_pages((ulong)fusion, > instance->ctrl_context_pages); > + } > } Braces are still not balanced in the above code. This is something checkpatch should have told you. Anyway: Reviewed-by: Bart Van Assche