Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbdIOSkQ (ORCPT ); Fri, 15 Sep 2017 14:40:16 -0400 Received: from mail-pg0-f42.google.com ([74.125.83.42]:49087 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbdIOSkO (ORCPT ); Fri, 15 Sep 2017 14:40:14 -0400 X-Google-Smtp-Source: ADKCNb63jIyvPIEerm8qrZcjlAZ9Agxr34ewU0eydKgVDiXbpxtXkL7QickdH9AyRaBPeuth87ba0w== Date: Fri, 15 Sep 2017 11:40:11 -0700 From: Bjorn Andersson To: Chris Lew Cc: andy.gross@linaro.org, david.brown@linaro.org, aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit Message-ID: <20170915184011.GR2016@tuxbook> References: <1505424302-29147-1-git-send-email-clew@codeaurora.org> <1505424302-29147-5-git-send-email-clew@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505424302-29147-5-git-send-email-clew@codeaurora.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 448 Lines: 16 On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote: > In V12 SMEM, SBL writes SMEM parameter information > after the TOC. Use the SBL provided item count > as the max item number. Please wrap your commit messages at 72 chars (50 for the subject). [..] > +static u32 qcom_smem_get_dynamic_item(struct qcom_smem *smem) This naming is too similar to the functions for looking up items, please rename it to "qcom_smem_get_item_count()". Regards, Bjorn