Subject: Re: [PATCH v2 3/3] KVM: SVM: Add irqchip_split() checks before
 enabling AVIC
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
References: <1505230962-86304-1-git-send-email-suravee.suthikulpanit@amd.com>
 <1505230962-86304-4-git-send-email-suravee.suthikulpanit@amd.com>
 <20170914152031.GA23415@flask> <3603043c-964f-d10c-8cc0-fa3476e3bbb5@amd.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com,
        joro@8bytes.org
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Message-ID: <dcbe0fce-3d7a-d519-835f-872bf0e65ed2@amd.com>
Date: Fri, 15 Sep 2017 12:21:15 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <3603043c-964f-d10c-8cc0-fa3476e3bbb5@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 19:21:18.8602 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1740
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1642
Lines: 49

Radim,

On 9/14/17 08:23, Suravee Suthikulpanit wrote:
> Radim,
>
> On 9/14/17 08:20, Radim Krčmář wrote:
>>> @@ -1594,6 +1593,12 @@ static int avic_init_vcpu(struct vcpu_svm *svm)
>>>      if (!avic)
>>>          return 0;
>>>
>>> +    if (!kvm_vcpu_apicv_active(&svm->vcpu)) {
>>> +        pr_debug("%s: Disable AVIC due to non-split irqchip.\n",
>>> +                  __func__);
>> We need to have an extra condition just because of this print ...
>> I removed the print altogether when applying -- I thought more about
>> that and it was aimed at people who wonder why AVIC was suddenly
>> disabled and it's unlikely that they will enable a debug message without
>> already knowing the reason,
>
> Make sense. Thanks.
>
>>
>> thanks.
>>
>>> @@ -4388,7 +4393,7 @@ static void svm_set_virtual_x2apic_mode(struct kvm_vcpu
>>> *vcpu, bool set)
>>>
>>>  static bool svm_get_enable_apicv(struct kvm_vcpu *vcpu)
>>>  {
>> A close contender was pr_info_once() here:
>>
>>     if (avic && !irqchip_split(vcpu->kvm))
>>         pr_info_once(...)
>>
>
> Looks good.

Actually, thinking about it again, this would not work either since 
pr_xxx_once() would only print the message once per loading of kvm_amd module. 
However, we would prefer the message to be printed per VM initialization. I also 
tried adding the check and print this message in the kvm_x86_ops.vm_init(), but 
this also does not work since the vm_init() function is called before the 
kvm_vm_ioctl_enable_cap(KVM_CAP_SPLIT_IRQCHIP).

Therefore, pr_info() might be better here, even though this would get print per 
VCPU initialization. Any other suggestions?

Thanks,
Suravee